Save image on CTRL+S

[ioalexander]

Enhancement: Prevent browser default behavior when pressing Ctrl + S on an open image, which would otherwise trigger image saving.

Checklist

• Tests written for new code (and old code if feasible).
• New or updated public/exported symbols have accurate TSDoc documentation.
• [X ] Linter and other CI checks pass.
• I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

[CLAassistant]

All committers have signed the CLA.

[dbkr]

Few comments, but also this would need a test of some kind. Nice feature though.

[dbkr]

Actually, having done that round of review, I've just noticed this really should be using the same code as the existing download image button on the message action bar: https://github.com/element-hq/element-web/blob/develop/src/components/views/messages/DownloadActionButton.tsx - Ithink the right way to do this would be to factor that code out and make it re-usable.

[ioalexander]

Thanks for flagging this @dbkr

I’ve refactored the download logic into useDownloadMedia hook.

I’ve added a new test to cover the Ctrl+S keyboard shortcut in the ImageView. CTRL+S now triggers the download in the DownloadButton

Looking forward for a review!

[ioalexander]

@dbkr I've merged in the updates and removed the forwardRef usage.
I’m seeing an i18n failure now - I'm not sure if it’s related to my changes. Is this fine as it should be?

[dbkr]

Ah, you read my mind: I was staring at the function passed back from forwardRef for quite a while trying to work out what it was doing. Thanks, I think this is much easier to understand.

Also thanks for spotting and merging in the upstream fix (which I noticed thanks to reviewing this PR!)

For the i18n check, you should just be able to run yarn i18n and it will scan all the files for translatable strings and put them in the file for you.

[ioalexander]

@dbkr i18n applied

[dbkr]

Thanks! I think our sonarcloud is unhappy because you're trying to contribute from your develop branch (I though we had a thing that warns you but it doesn't seem to have triggered). Would you mind changing to a different branch on your fork, then I think this is good to go.

[ioalexander]

@dbkr here you go: #30330
Closing this PR