-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix e2e icon colour #30299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix e2e icon colour #30299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3dd1253 to
1ca4df9
Compare
MidhunSureshR
approved these changes
Jul 10, 2025
t3chguy
reviewed
Jul 10, 2025
res/css/views/rooms/_E2EIcon.pcss
Outdated
Comment on lines
65
to
67
| .mx_E2EIcon_verified, .mx_E2EIcon_warning .mx_E2EIcon_normal::after { | ||
| mask-size: 90%; | ||
| background-color: white; | ||
| } |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the bg color removed, what mask is being downsized to 90%?
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the mask f1b1898
uhoreg
approved these changes
Jul 10, 2025
RiotRobot
pushed a commit
that referenced
this pull request
Jul 10, 2025
* fix: remove white background on e2e verification icon and put white on the checkmark * test(e2e): add non regression tests * chore: remove unused CSS mask (cherry picked from commit a05ca97)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
* fix: remove white background on e2e verification icon and put white on the checkmark * test(e2e): add non regression tests * chore: remove unused CSS mask (cherry picked from commit a05ca97) Co-authored-by: Florian Duros <[email protected]>
Dileep9999
pushed a commit
to hemanth-nag/element-web
that referenced
this pull request
Oct 8, 2025
* fix: remove white background on e2e verification icon and put white on the checkmark * test(e2e): add non regression tests * chore: remove unused CSS mask
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30293
Regression due to #30235