Skip to content

Simplified Sliding Sync #28515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
Mar 18, 2025
Merged

Simplified Sliding Sync #28515

merged 48 commits into from
Mar 18, 2025

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Nov 21, 2024

Replaces the sliding sync option in labs with Simplified Sliding Sync so it will support the impl in Synapse directly rather than via the sliding sync proxy.

Anyone who had the old labs flag turned on will find that their client breaks very abruptly when updated: it will simply throw an error when it tries to start syncing. This is done deliberately to fail fast since otherwise it could cause subtle crypto failures with both a proxy and the client syncing directly. matrix.org has not run a sliding sync proxy for some time but other homeservers may still be running one.

This is still a way from perfect but getting it into labs is a place where we can start getting it ready for primetime.

Requires matrix-org/matrix-js-sdk#4400
Ported from element-hq/matrix-react-sdk#36

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dbkr dbkr requested a review from a team as a code owner February 19, 2025 17:33
@dbkr dbkr requested review from t3chguy and florianduros February 19, 2025 17:33
as they're not displayed anywhere so not useful
dbkr added 7 commits March 6, 2025 13:48
by making it not a feature
and minus the bit about disabling notification which surely would have
defeated the original point anyway?
...and also make tests actually use sliding sync
@dbkr dbkr added this pull request to the merge queue Mar 18, 2025
Merged via the queue into develop with commit f59af37 Mar 18, 2025
31 of 32 checks passed
@dbkr dbkr deleted the dbkr/sss branch March 18, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants