Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC: remove auth params from url after login attempt #25664

Merged
merged 2 commits into from
Jun 27, 2023
Merged

OIDC: remove auth params from url after login attempt #25664

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b51b87
remove auth params from url after login attempt
Jun 27, 2023
5293e0b
Merge branch 'develop' into kerry/25657/remove-login-queryparams
Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/vector/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,17 @@ function makeRegistrationUrl(params: QueryDict): string {

function onTokenLoginCompleted(): void {
// if we did a token login, we're now left with the token, hs and is
// url as query params in the url; a little nasty but let's redirect to
// clear them.
// url as query params in the url;
// if we did an oidc authorization code flow login, we're left with the auth code and state
// as query params in the url;
// a little nasty but let's redirect to clear them.
const url = new URL(window.location.href);

url.searchParams.delete("loginToken");
url.searchParams.delete("state");
url.searchParams.delete("code");

logger.log(`Redirecting to ${url.href} to drop loginToken from queryparams`);
logger.log(`Redirecting to ${url.href} to drop delegated authentication params from queryparams`);
window.history.replaceState(null, "", url.href);
}

Expand Down