Use URLSearchParams instead of transitive dependency querystring
#13138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
…uy/querystring � Conflicts: � package.json � src/@types/global.d.ts � src/vector/app.tsx � src/vector/jitsi/index.ts � src/vector/platform/WebPlatform.ts � yarn.lock
jryans
approved these changes
Jul 16, 2021
williamkray
pushed a commit
to williamkray/element-web
that referenced
this pull request
Jul 28, 2021
[Full Changelog](element-hq/element-web@v1.7.33...v1.7.34-rc.1) * Translations update from Weblate [\element-hq#18260](element-hq#18260) * Update ESLint config [\element-hq#18236](element-hq#18236) * Update matrix-org-eslint-plugin and tighten max warning limit [\element-hq#18207](element-hq#18207) * Update webpack path for new voice message worker location [\element-hq#18187](element-hq#18187) * yarn upgrade [\element-hq#18150](element-hq#18150) * Conform to new typescript eslint rules [\element-hq#18065](element-hq#18065) * Add the Matrix Space to the translations guide [\element-hq#18102](element-hq#18102) * Update eslint-plugin-matrix-org [\element-hq#18058](element-hq#18058) * Fix browser history getting stuck looping back to the same room [\element-hq#18053](element-hq#18053) * Use URLSearchParams instead of transitive dependency `querystring` [\element-hq#13138](element-hq#13138) * Update PR template for new changelog generation [\element-hq#18003](element-hq#18003) * Fix space shortcuts on layouts with non-English keys in the places of numbers [\element-hq#17780](element-hq#17780) * Add comment around feature_spaces flag usage [\element-hq#18006](element-hq#18006) * Standardise casing of identity server [\element-hq#17980](element-hq#17980) * Convert CONTRIBUTING to markdown [\element-hq#18002](element-hq#18002) * Ignore workers for jest tests because it disagrees with worker-loader [\element-hq#17999](element-hq#17999) * Use webpack worker-loader instead of homegrown hack [\element-hq#17963](element-hq#17963) * Fix types to match Typescripted IndexedDB store [\element-hq#17962](element-hq#17962) * Improve and consolidate typing [\element-hq#17931](element-hq#17931)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We really need to stop using transitive dependencies like this. It could cause our app to break if we remove an unrelated dep or if they change their deps.
For #7842
Requires matrix-org/matrix-react-sdk#4399