Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ElectronPlatform: Add support for a event index using Seshat. #11125
ElectronPlatform: Add support for a event index using Seshat. #11125
Changes from 29 commits
1dbdd0a
71023ae
94196eb
a6839af
c3c5756
449eca6
437c59f
e9352fc
b90a94b
7147af8
dd2c210
076bf6f
0813aff
b17a403
4a25252
73b302f
137bedb
2f2cbad
d0b5391
e96c44c
4c629e8
da4b403
b52141d
5f6636e
b1aff29
40f2648
f0fe968
5b8e918
1869350
b0783a8
f28f27a
e5956de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, so is
electron-build-env
needed even for the first installation of thematrix-seshat
Node module, or is only a rebuild helper?If it's only used for rebuilds, I wonder if we can find some way to repeat the build that happens at install time without this extra tool somehow, such as
(cd node_modules/matrix-seshat; yarn run install)
or similar.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed that the Electron docs suggest
electron-rebuild
, is that of any use here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's only needed to rebuild it, but I'm not 100% on that.
The neon docs state this:
As far as I can tell this has not changed as of yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking around a bit, it's quite difficult to follow what's actually recommended and also matches what we need here. 😓 I don't want to block all this work on sorting it out though, so I filed a separate issue to improve this in a future step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a short explanation of this flag in the labs docs as per the guide.