Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined tag request #444

Closed
manuroe opened this issue Nov 30, 2015 · 3 comments
Closed

undefined tag request #444

manuroe opened this issue Nov 30, 2015 · 3 comments

Comments

@manuroe
Copy link
Member

manuroe commented Nov 30, 2015

If you move a room from "conversations" to the last position of the "favourites" section, the app makes a request to tag the room with "undefined":
https://matrix.org/_matrix/client/v2_alpha/user/%40Manu%3Amatrix.org/rooms/!GzvmKcFNOiOmXzAQgi%3Amatrix.org/tags/undefined?access_token=...

@ara4n
Copy link
Member

ara4n commented Nov 30, 2015

The request is a DELETE, no? So it's just trying to delete the previous
non-existent tag on the untagged room?

On 30/11/2015 15:44, manuroe wrote:

If you move a room from "conversations" to the last position of the
"favourites" section, the app makes a request to tag the room with
"undefined":
https://matrix.org/_matrix/client/v2_alpha/user/%40Manu%3Amatrix.org/rooms/!GzvmKcFNOiOmXzAQgi%3Amatrix.org/tags/undefined?access_token=...

— Reply to this email directly or view it on GitHub
#444.

@ara4n
Copy link
Member

ara4n commented Nov 30, 2015

Hopefully fixed in 4409f07 - @manuroe can you confirm this is the bad behaviour you were seeing?

@ara4n ara4n closed this as completed Nov 30, 2015
@manuroe
Copy link
Member Author

manuroe commented Nov 30, 2015

Yes, this is a DELETE request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants