Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refreshing /develop shows brief(?) VoIP inbound call notifications which may flicker on & off as it resyncs #3572

Closed
ara4n opened this issue Apr 5, 2017 · 3 comments · Fixed by matrix-org/matrix-js-sdk#1082
Closed

refreshing /develop shows brief(?) VoIP inbound call notifications which may flicker on & off as it resyncs #3572

ara4n opened this issue Apr 5, 2017 · 3 comments · Fixed by matrix-org/matrix-js-sdk#1082
Labels
A-VoIP P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Apr 5, 2017

No description provided.

@lampholder lampholder added T-Defect X-Cannot-Reproduce X-Needs-Info This issue is blocked awaiting information from the reporter labels Apr 6, 2017
@lampholder
Copy link
Member

I tried refreshing /develop in a room that had had some VoIP activity and nothing popped up for me - have you got any more context you can add to help reproduce?

@ara4n ara4n mentioned this issue Apr 22, 2017
Closed
@ara4n ara4n added P1 A-VoIP S-Minor Impairs non-critical functionality or suitable workarounds exist and removed X-Cannot-Reproduce X-Needs-Info This issue is blocked awaiting information from the reporter labels Apr 22, 2017
@ara4n
Copy link
Member Author

ara4n commented Apr 22, 2017

Have two clients; keep placing calls from A to B, hanging up, and then refreshing B. Within about 5-10 attempts you'll find that B starts ringing during sync - and never shuts up even if you reject the call.

@ara4n ara4n changed the title refreshing /develop shows brief VoIP inbound call notifications which flicker on & off as it resyncs refreshing /develop shows brief(?) VoIP inbound call notifications which may flicker on & off as it resyncs Apr 22, 2017
@ara4n ara4n mentioned this issue Apr 22, 2017
Closed
@lofidevops lofidevops mentioned this issue Nov 7, 2018
Open
@dalcde dalcde mentioned this issue Jun 2, 2019
Closed
@jryans
Copy link
Collaborator

jryans commented Jun 3, 2019

Keywords: incoming call on start

@jryans jryans added S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jun 3, 2019
dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Nov 21, 2019
@dbkr
Fix ringing chirp on loading
3a9832a 
We have a heap of logic to do the right thing when a call event
arrives, eg. wait until the client is ready so we can see if there's
already been a hangup event before saying there's an incoming call.

Unfortunately it only waited until the client was prepared, not
until it was syncing, so any events that arrived from the server
in the catchup sync bypassed this logic altogether.

This was probably broken back when we introduced the sync accumulator,
since before then, "PREPARED" meant, "done initialsync" rather than
"loaded fake initialsync from storage".

Fixes element-hq/element-web#3572
@dbkr dbkr mentioned this issue Nov 21, 2019
Merged
@532910 532910 mentioned this issue Feb 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-VoIP P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ringing chirp on loading matrix-org/matrix-js-sdk
3 participants
@jryans @ara4n @lampholder