Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when /versions succeeds but /sync fails, there is no disconnected indicator #3336

Closed
ara4n opened this issue Feb 28, 2017 · 3 comments · Fixed by matrix-org/matrix-js-sdk#410
Closed

when /versions succeeds but /sync fails, there is no disconnected indicator #3336

ara4n opened this issue Feb 28, 2017 · 3 comments · Fixed by matrix-org/matrix-js-sdk#410
Assignees
@lukebarnard1
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Milestone
RW002

Comments

@ara4n
Copy link
Member

ara4n commented Feb 28, 2017

No description provided.

@ara4n
Copy link
Member Author

ara4n commented Mar 8, 2017 •
edited
Loading

Quite possibly related to #2523 and also tangentially similar to #3318

The end result is that you can be disconnected from the server due to the synchrotrons having got wedged, but seemingly everything is fine...

@ara4n
Copy link
Member Author

ara4n commented Mar 8, 2017

prioritising as p1 'cos with synapse still being overloaded we expect to see more synchrotron meltdowns, and it's awful that it can result in everyone's riot's talking the void with no evidence of problems. It also gets in the way of diagnosing when the synchrotrons are screwed, because we could legitimately just notice ourselves for minutes on end.

@ara4n ara4n added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround P1 ui/ux labels Mar 8, 2017
@lampholder lampholder added this to the RW002 milestone Apr 3, 2017
@lukebarnard1 lukebarnard1 self-assigned this Apr 3, 2017
@lukebarnard1
Copy link
Contributor

So my hunch is that successfully calling /versions but encountering an error on /sync leads to the sync state being left in RECONNECTING. I'll make a PR that includes this sync state as another possible indication of connection loss.

lukebarnard1 pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 3, 2017
Fix status bar not appearing for sync state = RECONNECTING
92c2a58 
Previously, only a state of ERROR would cause the indicator to show. When /versions succeeds but /sync fails, RECONNECTING is the resulting sync state.

This fix will cause RoomStatusBar to treat RECONNECTING in the same way as it treats ERROR.

Fixes element-hq/element-web#3336
This was referenced Apr 3, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebarnard1 lukebarnard1

Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
RW002
3 participants
@ara4n @lampholder @lukebarnard1