UX: Improve Visibility of Encryption "Lock" Icons

[tessgadwa]

Chat "lock" icon indicating whether a conversation is encrypted or unencrypted is light gray and very easy to overlook. This leads to confusion about whether a convo is encrypted or not. Several people have mentioned this issue. Suggest a simple fix -- adding color to lock icons. I am enclosing two variants--gold and cobalt--as well as the original gray

for comparison, in both light and dark themes.

I would recommend same color be used for locked and unlocked states.

Let me know if folks have other thoughts re: color and visibility. If not I will submit new SVGs as a PR.

[tessgadwa]

Third option (referenced from last night's discussion online): black lock for light theme, white lock for dark theme.

[tessgadwa]

See thread https://matrix.to/#/!DgvjtOljKujDBrxyHk:matrix.org/%241487971316629269UYhJd:matrix.org

[richvdh]

Dup of #2850, which has been addressed on develop

[uhoreg]

@richvdh there were some comments in one of the rooms that some people didn't like the "Send a message (unencrypted)" message that was implemented. This was meant as an alternative to that, which would still make it clearer that the room is unencrypted, but which would be less confusing to people.

[richvdh]

If the issue is "we don't like 'Send a message (unencrypted)'", probably best to open an issue explaining why. This issue didn't seem to even mention that message.

[tessgadwa]

Comment purely for clarification -- issue was opened bc gray color of both locked and unlocked encryption icons makes them exceedingly easy to overlook.