Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inlined mentions properly #2980

Closed
MightyCreak opened this issue Jan 18, 2017 · 12 comments
Closed

Support inlined mentions properly #2980

MightyCreak opened this issue Jan 18, 2017 · 12 comments

Comments

@MightyCreak
Copy link

Right now, I think the mentioning system is quite verbosy:

capture d ecran 2017-01-18 a 10 32 36

I propose to hide all that in a nice manner by adding the avatar before the user's name and removing the server info (this is pure UI, nothing to change on matrix). Here is a mockup I've made:

riot_mention_proposition

On the UX side, the common "@" to make a mention is replaced by the actual avatar of the user, so we're pretty sure who it is, also when hovering the mouse on the name or the avatar, your see the whole ID "@user:server.com".

@uhoreg
Copy link
Member

uhoreg commented Jan 18, 2017

related to #553

@ara4n
Copy link
Member

ara4n commented Jan 18, 2017

Yup. this precisely how mentions are meant to work. The intention is that the mention is sent as <a href="mx://matrix.org/user/matthew">Matthew (@matthew:matrix.org)</a>, and any client smart enough to parse the a tag will go and render it as you propose. Less intelligent clients which can't handle HTML messages would then fall back to the plain text, which would behave as it does today.

@ara4n ara4n changed the title Mention UX proposition Support inlined mentions properly Jan 18, 2017
@MightyCreak
Copy link
Author

part of #2984

@ara4n
Copy link
Member

ara4n commented May 15, 2017

(there's also a debate on whether these should be <a href= or <a rel= fwiw.)

@grahamperrin
Copy link

… adding the avatar …

Re: element-hq/element-meta#1589 I prefer the cleanliness of mentions without avatars.

Without a circle at one end of the pill, the two rounded ends appear strange, so (for myself) I added to Stylish to improve the shape – and make the text more legible with a dark theme:

  .mx_UserPill {
    height: 1;
    line-height: 1;
    border-radius: 3px;
    border: none;
    background: rgb(0, 0, 0) !important;
    padding: .2em;
  }

Screenshot: https://matrix.to/#/!DgvjtOljKujDBrxyHk:matrix.org/$15014320683017427xcRTL:matrix.org

@MightyCreak
Copy link
Author

I politely disagree. Please Riot devs, don't transform Riot into yet another IRC client.

As a user of other non-IRC software, I want avatars, I want rich-text edit, I want post edition, I want in-line preview, I want that the displayed text can elegantly hide some secondary information (like the complete ID), etc, etc.

I consider that if a Matrix user want to have an IRC UX, then maybe he should look at another client than Riot.

I know I won't make friends saying that, but IRC is simply too outdated to be taken as a reference.

@t3chguy
Copy link
Member

t3chguy commented Jul 30, 2017

@MightyCreak if it gets added it'll be a default-off option.

@MightyCreak
Copy link
Author

Why is it closed? There's a fix?

@t3chguy
Copy link
Member

t3chguy commented Aug 2, 2017

@MightyCreak yes - see https://riot.im/develop/

@MightyCreak
Copy link
Author

That's beautiful!
Well done, thanks!

@t3chguy
Copy link
Member

t3chguy commented Aug 2, 2017

It looks near-identical to your mockup @MightyCreak
and @lukebarnard1 is the one to thank, he did all the Pill stuff

@MightyCreak
Copy link
Author

Thanks @lukebarnard1 !! 😄 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants