Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emojis: Wait for the first letter before showing the emojis popup #2811

Closed
MightyCreak opened this issue Dec 24, 2016 · 4 comments
Closed

Emojis: Wait for the first letter before showing the emojis popup #2811

MightyCreak opened this issue Dec 24, 2016 · 4 comments

Comments

@MightyCreak
Copy link

Right now, as soon as we hit : the emojis list pops up. But some time we just really want to write : as in:

Example: this is a valid colon.

or

Check the list below:

  • one
  • two

The GitHub behavior is that if there is a letter just before the colon, then the popup doesn't show.
Personally, I think it's pretty useless to show the popup as soon as : is written. I think the rule should be:

If there is no letter before `:` and at least one letter after:
    Show the emoji popup filtered with the letter(s) after the `:`
@MightyCreak MightyCreak changed the title Wait for the first letter before showing the emojis popup Emojis: Wait for the first letter before showing the emojis popup Dec 24, 2016
@MightyCreak
Copy link
Author

MightyCreak commented Dec 24, 2016

In slack it even waits for the second letter to be written (but personally I don't like it).

Edit: I think they wait for the second letter so that the popup doesn't show when writing text smileys like :) :-) :D :P.
Personal opinion: I still think one letter is enough, especially since there are no emoji starting with ) or -, or even with an upper case letter if we really want to be pedantic.

@MightyCreak
Copy link
Author

Part of #2984

@Peque
Copy link

Peque commented Oct 9, 2021

As of 1.9.0 I think this may be implemented. At least, I need to type 2 characters to see the pop-over emoji suggestion list.

@aaronraimist
Copy link
Collaborator

I agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants