Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird blank tiles break vertical spacing and suggest missing events #253

Closed
ara4n opened this issue Oct 23, 2015 · 3 comments
Closed

Weird blank tiles break vertical spacing and suggest missing events #253

ara4n opened this issue Oct 23, 2015 · 3 comments
Assignees
@dbkr
Labels
P1 T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Oct 23, 2015

This may be because I set the timestamps to visibility: hidden rather than display: none, but nevertheless we have weird blank continuation li's which break everything.

screen shot 2015-10-23 at 21 41 35
@ara4n
Copy link
Member Author

ara4n commented Oct 25, 2015

Meanwhile, I'm seeing entirely blank tiles altogether, which (from clicking 'view source') appear to be lost join events?

screen shot 2015-10-25 at 11 58 20

@ara4n ara4n added P1 and removed P2 labels Oct 25, 2015
@ara4n ara4n changed the title Weird blank continuations break vertical spacing Weird blank tiles break vertical spacing and suggest missing events Oct 25, 2015
@stevenhammerton
Copy link

This can be quite bad / ugly in quite channels with many joins / parts.

image

dbkr added a commit that referenced this issue Nov 2, 2015
@dbkr
Don't display anything if TextForEvent doesn't give us any text. Fixes …
e869814 
…#253 (catapillar of doom).
@dbkr
Copy link
Member

dbkr commented Nov 16, 2015

Fixed.

@dbkr dbkr closed this as completed Nov 16, 2015
@ara4n ara4n modified the milestone: Ragnarok Nov 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbkr dbkr

Labels
P1 T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbkr @ara4n @stevenhammerton