Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unread count increments when opening the threads panel #24164

Closed
weeman1337 opened this issue Jan 5, 2023 · 0 comments · Fixed by matrix-org/matrix-js-sdk#3031
Closed

Unread count increments when opening the threads panel #24164

weeman1337 opened this issue Jan 5, 2023 · 0 comments · Fixed by matrix-org/matrix-js-sdk#3031
Assignees
@germain-gg
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@weeman1337
Copy link
Contributor

weeman1337 commented Jan 5, 2023 •
edited
Loading

Steps to reproduce

  1. Have threads enabled
  2. Have a room with unread messages in threads
  3. Go to the room
  4. Open the threads panel

Outcome

What did you expect?

Unread count should not change

What happened instead?

Unread count increments

Can currently 100 % reproduce this.

See logs for a screen recording (not sharing here, because it contains sensible information).

Operating system

Ubuntu 22.04.1 LTS

Application version

Element Nightly version: 2023010401 Olm version: 3.2.12

How did you install the app?

https://packages.element.io/debian/

Homeserver

No response

Will you send logs?

Yes
@weeman1337 weeman1337 changed the title Unread count goes crazy when opening the threads panel Unread count increments when opening the threads panel Jan 5, 2023
@germain-gg germain-gg added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jan 5, 2023
@germain-gg germain-gg self-assigned this Jan 5, 2023
This was referenced Jan 5, 2023
Merged
Merged
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Jan 19, 2023
@su-ex
Merge tag 'v23.1.0' into sc
e6c127a 
* Remove extensible events v1 field population on legacy events ([\matrix-org#3040](matrix-org#3040)).
* Improve hasUserReadEvent and getUserReadUpTo realibility with threads ([\matrix-org#3031](matrix-org#3031)). Fixes element-hq/element-web#24164.
* Remove video track when muting video ([\matrix-org#3028](matrix-org#3028)). Fixes element-hq/element-call#209.
* Make poll start event type available (PSG-962) ([\matrix-org#3034](matrix-org#3034)).
* Add alt event type matching in Relations model ([\matrix-org#3018](matrix-org#3018)).
* Remove usage of v1 Identity Server API ([\matrix-org#3003](matrix-org#3003)).
* Add `device_id` to `/account/whoami` types ([\matrix-org#3005](matrix-org#3005)).
* Implement MSC3912: Relation-based redactions ([\matrix-org#2954](matrix-org#2954)).
* Introduce a mechanism for using the rust-crypto-sdk ([\matrix-org#2969](matrix-org#2969)).
* Support MSC3391: Account data deletion ([\matrix-org#2967](matrix-org#2967)).
* Fix threaded cache receipt when event holds multiple receipts ([\matrix-org#3026](matrix-org#3026)).
* Fix false key requests after verifying new device ([\matrix-org#3029](matrix-org#3029)). Fixes element-hq/element-web#24167 and element-hq/element-web#23333.
* Avoid triggering decryption errors when decrypting redacted events ([\matrix-org#3004](matrix-org#3004)). Fixes element-hq/element-web#24084.
* bugfix: upload OTKs in sliding sync mode ([\matrix-org#3008](matrix-org#3008)).
* Apply edits discovered from sync after thread is initialised ([\matrix-org#3002](matrix-org#3002)). Fixes element-hq/element-web#23921.
* Sliding sync: Fix issue where no unsubs are sent when switching rooms ([\matrix-org#2991](matrix-org#2991)).
* Threads are missing from the timeline ([\matrix-org#2996](matrix-org#2996)). Fixes element-hq/element-web#24036.
* Close all streams when a call ends ([\matrix-org#2992](matrix-org#2992)). Fixes element-hq/element-call#742.
* Resume to-device message queue after resumed sync ([\matrix-org#2920](matrix-org#2920)). Fixes matrix-org/element-web-rageshakes#17170.
* Fix browser entrypoint ([\matrix-org#3051](matrix-org#3051)). Fixes matrix-org#3013.
* Fix failure to start in firefox private browser ([\matrix-org#3058](matrix-org#3058)). Fixes element-hq/element-web#24216.
* Correctly handle limited sync responses by resetting the thread timeline ([\matrix-org#3056](matrix-org#3056)). Fixes element-hq/element-web#23952.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve hasUserReadEvent and getUserReadUpTo realibility with threads matrix-org/matrix-js-sdk
2 participants
@germain-gg @weeman1337