-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken layout for threads where the root message is an emote #23897
Closed
Labels
A-Emotes
A-Threads
O-Occasional
Affects or can be seen by some users regularly or most users rarely
S-Minor
Impairs non-critical functionality or suitable workarounds exist
T-Defect
Comments
SimonBrandner
added
S-Minor
Impairs non-critical functionality or suitable workarounds exist
A-Emotes
O-Occasional
Affects or can be seen by some users regularly or most users rarely
labels
Dec 3, 2022
su-ex
added a commit
to SchildiChat/matrix-react-sdk
that referenced
this issue
Feb 1, 2023
* Quotes for rte ([\matrix-org#9932](matrix-org#9932)). Contributed by @alunturner. * Show the room name in the room header during calls ([\matrix-org#9942](matrix-org#9942)). Fixes element-hq/element-web#24268. * Add code blocks to rich text editor ([\matrix-org#9921](matrix-org#9921)). Contributed by @alunturner. * Add new style for inline code ([\matrix-org#9936](matrix-org#9936)). Contributed by @florianduros. * Add disabled button state to rich text editor ([\matrix-org#9930](matrix-org#9930)). Contributed by @alunturner. * Change the rageshake "app" for auto-rageshakes ([\matrix-org#9909](matrix-org#9909)). * Device manager - tweak settings display ([\matrix-org#9905](matrix-org#9905)). Contributed by @kerryarchibald. * Add list functionality to rich text editor ([\matrix-org#9871](matrix-org#9871)). Contributed by @alunturner. * Fix RTE focus behaviour in threads ([\matrix-org#9969](matrix-org#9969)). Fixes element-hq/element-web#23755. Contributed by @florianduros. * #22204 Issue: Centered File info in lightbox ([\matrix-org#9971](matrix-org#9971)). Fixes element-hq/element-web#22204. Contributed by @Spartan09. * Fix seekbar position for zero length audio ([\matrix-org#9949](matrix-org#9949)). Fixes element-hq/element-web#24248. * Allow thread panel to be closed after being opened from notification ([\matrix-org#9937](matrix-org#9937)). Fixes element-hq/element-web#23764 element-hq/element-web#23852 and element-hq/element-web#24213. Contributed by @justjanne. * Only highlight focused menu item if focus is supposed to be visible ([\matrix-org#9945](matrix-org#9945)). Fixes element-hq/element-web#23582. * Prevent call durations from breaking onto multiple lines ([\matrix-org#9944](matrix-org#9944)). * Tweak call lobby buttons to more closely match designs ([\matrix-org#9943](matrix-org#9943)). * Do not show a broadcast as live immediately after the recording has stopped ([\matrix-org#9947](matrix-org#9947)). Fixes element-hq/element-web#24233. * Clear the RTE before sending a message ([\matrix-org#9948](matrix-org#9948)). Contributed by @florianduros. * Fix {enter} press in RTE ([\matrix-org#9927](matrix-org#9927)). Contributed by @florianduros. * Fix the problem that the password reset email has to be confirmed twice ([\matrix-org#9926](matrix-org#9926)). Fixes element-hq/element-web#24226. * replace .at() with array.length-1 ([\matrix-org#9933](matrix-org#9933)). Fixes matrix-org/element-web-rageshakes#19281. * Fix broken threads list timestamp layout ([\matrix-org#9922](matrix-org#9922)). Fixes element-hq/element-web#24243 and element-hq/element-web#24191. Contributed by @justjanne. * Disable multiple messages when {enter} is pressed multiple times ([\matrix-org#9929](matrix-org#9929)). Fixes element-hq/element-web#24249. Contributed by @florianduros. * Fix logout devices when resetting the password ([\matrix-org#9925](matrix-org#9925)). Fixes element-hq/element-web#24228. * Fix: Poll replies overflow when not enough space ([\matrix-org#9924](matrix-org#9924)). Fixes element-hq/element-web#24227. Contributed by @kerryarchibald. * State event updates are not forwarded to the widget from invitation room ([\matrix-org#9802](matrix-org#9802)). Contributed by @maheichyk. * Fix error when viewing source of redacted events ([\matrix-org#9914](matrix-org#9914)). Fixes element-hq/element-web#24165. Contributed by @clarkf. * Replace outdated css attribute ([\matrix-org#9912](matrix-org#9912)). Fixes element-hq/element-web#24218. Contributed by @justjanne. * Clear isLogin theme override when user is no longer viewing login screens ([\matrix-org#9911](matrix-org#9911)). Fixes element-hq/element-web#23893. * Fix reply action in message context menu notif & file panels ([\matrix-org#9895](matrix-org#9895)). Fixes element-hq/element-web#23970. * Fix issue where thread dropdown would not show up correctly ([\matrix-org#9872](matrix-org#9872)). Fixes element-hq/element-web#24040. Contributed by @justjanne. * Fix unexpected composer growing ([\matrix-org#9889](matrix-org#9889)). Contributed by @florianduros. * Fix misaligned timestamps for thread roots which are emotes ([\matrix-org#9875](matrix-org#9875)). Fixes element-hq/element-web#23897. Contributed by @justjanne.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Emotes
A-Threads
O-Occasional
Affects or can be seen by some users regularly or most users rarely
S-Minor
Impairs non-critical functionality or suitable workarounds exist
T-Defect
Steps to reproduce
Outcome
The timestamp for the thread in the thread list is rendered underneath the avatar of the root message author.
It's also missing the user name. We should include it in the context of the thread list, even if the root message happens to be an emote.
Operating system
macOS
Browser information
Chrome 108.0.5359.71
URL for webapp
develop.element.io
Application version
Element version: eb6d617-react-0358e038a9ae-js-779980476273 Olm version: 3.2.12
Homeserver
No response
Will you send logs?
No
The text was updated successfully, but these errors were encountered: