-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird black vertical gradient over image thumbnails in bubble view. #21651
Comments
See #20402 for context of why the gradient exists (yes, it is for timestamp legibility) |
right, timestamp legibility makes sense... but not at the expense of getting a faithful thumbnail. the easy workaround would be to only show the gradient on hoverover (or put the timestamp on a smaller grey plinth like TG does) |
Yeah, and actually, I still find the gradient a bit insufficient for legibility against certain images, so a plinth would be welcome. |
fixed in favour of a plinth, thank heavens |
oh :( plz can kill with 🔥 |
In its current state it is broken, only works on transparent images so the layering order is wrong. |
given we now show timestamps with a nice lozenge overlay, so the gradient is unnecessary and just screws up the image. fixes element-hq/element-web#21651
* remove the grey gradient on images in the timeline given we now show timestamps with a nice lozenge overlay, so the gradient is unnecessary and just screws up the image. fixes element-hq/element-web#21651 * put a lozenge on the timestamp rather than evil gradient
* Element Call video rooms ([\#9267](matrix-org/matrix-react-sdk#9267)). * Device manager - rename session ([\#9282](matrix-org/matrix-react-sdk#9282)). * Allow widgets to read related events ([\#9210](matrix-org/matrix-react-sdk#9210)). Contributed by @dhenneke. * Device manager - logout of other session ([\#9280](matrix-org/matrix-react-sdk#9280)). * Device manager - logout current session ([\#9275](matrix-org/matrix-react-sdk#9275)). * Device manager - verify other devices ([\#9274](matrix-org/matrix-react-sdk#9274)). * Allow integration managers to remove users ([\#9211](matrix-org/matrix-react-sdk#9211)). * Device manager - add verify current session button ([\#9252](matrix-org/matrix-react-sdk#9252)). * Add NotifPanel dot back. ([\#9242](matrix-org/matrix-react-sdk#9242)). Fixes element-hq/element-web#17641. * Implement MSC3575: Sliding Sync ([\#8328](matrix-org/matrix-react-sdk#8328)). * Add the clipboard read permission for widgets ([\#9250](matrix-org/matrix-react-sdk#9250)). Contributed by @stefanmuhle. * Make autocomplete pop-up wider in thread view ([\#9289](matrix-org/matrix-react-sdk#9289)). * Fix soft crash around inviting invalid MXIDs in start DM on first message flow ([\#9281](matrix-org/matrix-react-sdk#9281)). Fixes matrix-org/element-web-rageshakes#15060 and matrix-org/element-web-rageshakes#15140. * Fix in-reply-to previews not disappearing when swapping rooms ([\#9278](matrix-org/matrix-react-sdk#9278)). * Fix invalid instanceof operand window.OffscreenCanvas ([\#9276](matrix-org/matrix-react-sdk#9276)). Fixes element-hq/element-web#23275. * Fix memory leak caused by unremoved listener ([\#9273](matrix-org/matrix-react-sdk#9273)). * Fix thumbnail generation when offscreen canvas fails ([\#9272](matrix-org/matrix-react-sdk#9272)). Fixes element-hq/element-web#23265. * Prevent sliding sync from showing a room under multiple sublists ([\#9266](matrix-org/matrix-react-sdk#9266)). * Fix tile crash around tooltipify links ([\#9270](matrix-org/matrix-react-sdk#9270)). Fixes element-hq/element-web#23253. * Device manager - filter out nulled metadatas in device tile properly ([\#9251](matrix-org/matrix-react-sdk#9251)). * Fix a sliding sync bug which could cause rooms to loop ([\#9268](matrix-org/matrix-react-sdk#9268)). * Remove the grey gradient on images in bubbles in the timeline ([\#9241](matrix-org/matrix-react-sdk#9241)). Fixes element-hq/element-web#21651. * Fix html export not including images ([\#9260](matrix-org/matrix-react-sdk#9260)). Fixes element-hq/element-web#22059. * Fix possible soft crash from a race condition in space hierarchies ([\#9254](matrix-org/matrix-react-sdk#9254)). Fixes matrix-org/element-web-rageshakes#15225. * Disable all types of autocorrect, -complete, -capitalize, etc on Spotlight's search field ([\#9259](matrix-org/matrix-react-sdk#9259)). * Handle M_INVALID_USERNAME on /register/available ([\#9237](matrix-org/matrix-react-sdk#9237)). Fixes element-hq/element-web#23161. * Fix issue with quiet zone around QR code ([\#9243](matrix-org/matrix-react-sdk#9243)). Fixes element-hq/element-web#23199.
* Element Call video rooms ([\element-hq#9267](matrix-org/matrix-react-sdk#9267)). * Device manager - rename session ([\element-hq#9282](matrix-org/matrix-react-sdk#9282)). * Allow widgets to read related events ([\element-hq#9210](matrix-org/matrix-react-sdk#9210)). Contributed by @dhenneke. * Device manager - logout of other session ([\element-hq#9280](matrix-org/matrix-react-sdk#9280)). * Device manager - logout current session ([\element-hq#9275](matrix-org/matrix-react-sdk#9275)). * Device manager - verify other devices ([\element-hq#9274](matrix-org/matrix-react-sdk#9274)). * Allow integration managers to remove users ([\element-hq#9211](matrix-org/matrix-react-sdk#9211)). * Device manager - add verify current session button ([\element-hq#9252](matrix-org/matrix-react-sdk#9252)). * Add NotifPanel dot back. ([\#9242](matrix-org/matrix-react-sdk#9242)). Fixes element-hq#17641. * Implement MSC3575: Sliding Sync ([\element-hq#8328](matrix-org/matrix-react-sdk#8328)). * Add the clipboard read permission for widgets ([\element-hq#9250](matrix-org/matrix-react-sdk#9250)). Contributed by @stefanmuhle. * Make autocomplete pop-up wider in thread view ([\element-hq#9289](matrix-org/matrix-react-sdk#9289)). * Fix soft crash around inviting invalid MXIDs in start DM on first message flow ([\element-hq#9281](matrix-org/matrix-react-sdk#9281)). Fixes matrix-org/element-web-rageshakes#15060 and matrix-org/element-web-rageshakes#15140. * Fix in-reply-to previews not disappearing when swapping rooms ([\element-hq#9278](matrix-org/matrix-react-sdk#9278)). * Fix invalid instanceof operand window.OffscreenCanvas ([\element-hq#9276](matrix-org/matrix-react-sdk#9276)). Fixes element-hq#23275. * Fix memory leak caused by unremoved listener ([\element-hq#9273](matrix-org/matrix-react-sdk#9273)). * Fix thumbnail generation when offscreen canvas fails ([\element-hq#9272](matrix-org/matrix-react-sdk#9272)). Fixes element-hq#23265. * Prevent sliding sync from showing a room under multiple sublists ([\element-hq#9266](matrix-org/matrix-react-sdk#9266)). * Fix tile crash around tooltipify links ([\element-hq#9270](matrix-org/matrix-react-sdk#9270)). Fixes element-hq#23253. * Device manager - filter out nulled metadatas in device tile properly ([\element-hq#9251](matrix-org/matrix-react-sdk#9251)). * Fix a sliding sync bug which could cause rooms to loop ([\element-hq#9268](matrix-org/matrix-react-sdk#9268)). * Remove the grey gradient on images in bubbles in the timeline ([\element-hq#9241](matrix-org/matrix-react-sdk#9241)). Fixes element-hq#21651. * Fix html export not including images ([\element-hq#9260](matrix-org/matrix-react-sdk#9260)). Fixes element-hq#22059. * Fix possible soft crash from a race condition in space hierarchies ([\element-hq#9254](matrix-org/matrix-react-sdk#9254)). Fixes matrix-org/element-web-rageshakes#15225. * Disable all types of autocorrect, -complete, -capitalize, etc on Spotlight's search field ([\element-hq#9259](matrix-org/matrix-react-sdk#9259)). * Handle M_INVALID_USERNAME on /register/available ([\element-hq#9237](matrix-org/matrix-react-sdk#9237)). Fixes element-hq#23161. * Fix issue with quiet zone around QR code ([\element-hq#9243](matrix-org/matrix-react-sdk#9243)). Fixes element-hq#23199.
* Element Call video rooms ([\matrix-org#9267](matrix-org#9267)). * Device manager - rename session ([\matrix-org#9282](matrix-org#9282)). * Allow widgets to read related events ([\matrix-org#9210](matrix-org#9210)). Contributed by @dhenneke. * Device manager - logout of other session ([\matrix-org#9280](matrix-org#9280)). * Device manager - logout current session ([\matrix-org#9275](matrix-org#9275)). * Device manager - verify other devices ([\matrix-org#9274](matrix-org#9274)). * Allow integration managers to remove users ([\matrix-org#9211](matrix-org#9211)). * Device manager - add verify current session button ([\matrix-org#9252](matrix-org#9252)). * Add NotifPanel dot back. ([\matrix-org#9242](matrix-org#9242)). Fixes element-hq/element-web#17641. * Implement MSC3575: Sliding Sync ([\matrix-org#8328](matrix-org#8328)). * Add the clipboard read permission for widgets ([\matrix-org#9250](matrix-org#9250)). Contributed by @stefanmuhle. * Make autocomplete pop-up wider in thread view ([\matrix-org#9289](matrix-org#9289)). * Fix soft crash around inviting invalid MXIDs in start DM on first message flow ([\matrix-org#9281](matrix-org#9281)). Fixes matrix-org/element-web-rageshakes#15060 and matrix-org/element-web-rageshakes#15140. * Fix in-reply-to previews not disappearing when swapping rooms ([\matrix-org#9278](matrix-org#9278)). * Fix invalid instanceof operand window.OffscreenCanvas ([\matrix-org#9276](matrix-org#9276)). Fixes element-hq/element-web#23275. * Fix memory leak caused by unremoved listener ([\matrix-org#9273](matrix-org#9273)). * Fix thumbnail generation when offscreen canvas fails ([\matrix-org#9272](matrix-org#9272)). Fixes element-hq/element-web#23265. * Prevent sliding sync from showing a room under multiple sublists ([\matrix-org#9266](matrix-org#9266)). * Fix tile crash around tooltipify links ([\matrix-org#9270](matrix-org#9270)). Fixes element-hq/element-web#23253. * Device manager - filter out nulled metadatas in device tile properly ([\matrix-org#9251](matrix-org#9251)). * Fix a sliding sync bug which could cause rooms to loop ([\matrix-org#9268](matrix-org#9268)). * Remove the grey gradient on images in bubbles in the timeline ([\matrix-org#9241](matrix-org#9241)). Fixes element-hq/element-web#21651. * Fix html export not including images ([\matrix-org#9260](matrix-org#9260)). Fixes element-hq/element-web#22059. * Fix possible soft crash from a race condition in space hierarchies ([\matrix-org#9254](matrix-org#9254)). Fixes matrix-org/element-web-rageshakes#15225. * Disable all types of autocorrect, -complete, -capitalize, etc on Spotlight's search field ([\matrix-org#9259](matrix-org#9259)). * Handle M_INVALID_USERNAME on /register/available ([\matrix-org#9237](matrix-org#9237)). Fixes element-hq/element-web#23161. * Fix issue with quiet zone around QR code ([\matrix-org#9243](matrix-org#9243)). Fixes element-hq/element-web#23199.
Might be related: #23409 |
Steps to reproduce
For instance, this screenshot:
...ends up looking like...
Outcome
What did you expect?
Thumbnails to show a faithful representation of the full resolution image
What happened instead?
Thumbnail shows big black gradient, presumably to ensure the timestamp is visible, but completely at the expense of the fidelity of the thumbnail, severely impacting its usability.
Operating system
macOS
Application version
Nightly
How did you install the app?
Nightly
Homeserver
matrix.org
Will you send logs?
No
The text was updated successfully, but these errors were encountered: