Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emotes and Rainbow emotes as the root message for a thread break the layout for thread tiles #20869

Closed
Tracked by #19669
janogarcia opened this issue Feb 2, 2022 · 0 comments · Fixed by matrix-org/matrix-react-sdk#7714
Closed
Tracked by #19669

Emotes and Rainbow emotes as the root message for a thread break the layout for thread tiles #20869

janogarcia opened this issue Feb 2, 2022 · 0 comments · Fixed by matrix-org/matrix-react-sdk#7714
Assignees
@germain-gg
Labels
A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Task Tasks for the team like planning Z-Labs

Comments

@janogarcia
Copy link

janogarcia commented Feb 2, 2022 •
edited
Loading

@gsouquet

  • Please add the user display name back for emotes in the thread list.
  • Make sure the thread tile is rendered correctly (timestamp, name...).
  • Make sure it works for both type of emotes, plain and rainbow colored.

emote as a thread root message
@janogarcia janogarcia mentioned this issue Feb 2, 2022
Closed
53 tasks
@github-actions github-actions bot added the Z-Labs label Feb 2, 2022
@janogarcia janogarcia changed the title Emotes and Rainbow emotes break as the root message for a thread break the layout for thread tiles Emotes and Rainbow emotes as the root message for a thread break the layout for thread tiles Feb 2, 2022
@janogarcia janogarcia added the T-Task Tasks for the team like planning label Feb 2, 2022
@dbkr dbkr added O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist labels Feb 2, 2022
germain-gg pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Feb 3, 2022
Force display sender profile for emotes in thread panel
8773fee 
Fixes element-hq/element-web#20869
@germain-gg germain-gg mentioned this issue Feb 3, 2022
Merged
@janogarcia janogarcia mentioned this issue Feb 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Task Tasks for the team like planning Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to thread UI matrix-org/matrix-react-sdk
3 participants
@janogarcia @germain-gg @dbkr