Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification settings not saving in macOS app #12289

Closed
fm opened this issue Feb 7, 2020 · 1 comment
Closed

Notification settings not saving in macOS app #12289

fm opened this issue Feb 7, 2020 · 1 comment
Labels
A-Notifications A-User-Settings T-Defect

Comments

@fm
Copy link

fm commented Feb 7, 2020

Description

Some notification settings are not saving in macOS app, it either does nothing; or spins like it's saving, but doesn't save changes

Steps to reproduce

  • Go to Settings -> Notifications
  • Switch Messages containing keywords from On to Noisy and nothing happens
  • Switch When rooms are upgraded from Noisy to On and it spins like it's saving, but does not save changes. Tried restarting app in case it was a cache issue, and effectively did not save.

Call invitation however, does save correctly. So does When I'm invited to a room

Video: https://ttm.sh/ESU.mov

Version information

  • Platform: desktop and web

  • OS: macOS Catalina 10.15.3

  • Versions:
    Desktop:
    matrix-react-sdk version: <local>
    riot-web version: 1.5.8
    olm version: 3.1.3
    Web:
    matrix-react-sdk version: <local>
    riot-web version: 1.4.2
    olm version: 3.1.0

  • Browser: Safari 13.0.5 (15608.5.11)

  • Web URL: https://riot.privacytools.io
@t3chguy
Copy link
Member

t3chguy commented Jul 10, 2023

Duplicate of #8632

@t3chguy t3chguy marked this as a duplicate of #8632 Jul 10, 2023
@t3chguy t3chguy closed this as completed Jul 10, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2023
t3chguy pushed a commit that referenced this issue Oct 17, 2024
@dbkr @robintown
Fix alignment of user menu avatar (#12289)
5ac222e 
* Fix alignment of user menu avatar

matrix-org/matrix-react-sdk#12267 made the avatar
a couple of pixels out of alignment with the space icons. It just needed
to be moved 2px to the right to match the 18px margin of the space icons
(including the padding from the black border).

Also change elements in the user menu to block elements so they don't
generate extra vertical space in the user menu div, which was causing the
hairline to be too far down.

* Update snapshots

* Typo

Co-authored-by: Robin <[email protected]>

* Reference the span by class

* The img wasn't actually necessary here

---------

Co-authored-by: Robin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Notifications A-User-Settings T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@t3chguy @fm @aaronraimist