-
Notifications
You must be signed in to change notification settings - Fork 2
Simplify the MAS config & allow overriding the Docker image #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
t3chguy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, but removing so many config options means tests can't override them without having to force types, as we infer the type from the default config. Unless those options have truly gone away should we keep some, e.g. branding?, policy wasm module?
|
@t3chguy Makes sense. We do have a JSON schema for the config, and I can do a one-shot generation for now, WDYT? |
|
Sure! |
|
Have done that in e4d64aa |
The intent is so that we can use the same image update mechanism from the
element-webrepo, so that we regularly pull MAS 'main' and pin it.I've also simplified the initial config to remove most of the 'default' fields
It also re-exports the Postgres testcontainer to make it easier to consume in EW