Skip to content

Conversation

@sandhose
Copy link
Member

@sandhose sandhose commented Aug 5, 2025

The intent is so that we can use the same image update mechanism from the element-web repo, so that we regularly pull MAS 'main' and pin it.

I've also simplified the initial config to remove most of the 'default' fields

It also re-exports the Postgres testcontainer to make it easier to consume in EW

@sandhose sandhose requested a review from a team as a code owner August 5, 2025 07:36
@sandhose sandhose requested review from MidhunSureshR and dbkr August 5, 2025 07:36
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, but removing so many config options means tests can't override them without having to force types, as we infer the type from the default config. Unless those options have truly gone away should we keep some, e.g. branding?, policy wasm module?

@sandhose
Copy link
Member Author

sandhose commented Aug 5, 2025

@t3chguy Makes sense. We do have a JSON schema for the config, and json-schema-to-typescript seems to generate a decent output: https://gist.github.com/sandhose/98345404b28ac359fff8ba7801dacde7

I can do a one-shot generation for now, WDYT?

@t3chguy
Copy link
Member

t3chguy commented Aug 5, 2025

Sure!

@sandhose
Copy link
Member Author

sandhose commented Aug 5, 2025

Have done that in e4d64aa

@sandhose sandhose requested a review from t3chguy August 5, 2025 08:55
@sandhose sandhose merged commit 35f1905 into main Aug 5, 2025
17 checks passed
@sandhose sandhose deleted the quenting/better-mas branch August 5, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants