Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump analytics event to v0.15.0 #7768

Merged
merged 4 commits into from
Mar 29, 2024
Merged

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Mar 27, 2024

Preliminary work for #7767

Update matrix-analytics-events to version 0.15.0

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@BillCarsonFr BillCarsonFr self-assigned this Mar 27, 2024
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a few minor requests. Not sure what's up with CI haven't seen those errors before and they seem unrelated to this PR. Have re-run them to see 🤞

Riot/Modules/Analytics/Analytics.swift Outdated Show resolved Hide resolved
Riot/Modules/Analytics/Analytics.swift Outdated Show resolved Hide resolved
changelog.d/7768.misc Outdated Show resolved Hide resolved
changelog.d/7768.misc Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 12.33%. Comparing base (c89637d) to head (09af055).

Files Patch % Lines
Riot/Modules/Analytics/Analytics.swift 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7768      +/-   ##
===========================================
- Coverage    12.34%   12.33%   -0.01%     
===========================================
  Files         1650     1650              
  Lines       164090   164100      +10     
  Branches     67503    67503              
===========================================
  Hits         20249    20249              
- Misses      143153   143163      +10     
  Partials       688      688              
Flag Coverage Δ
unittests 6.20% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@BillCarsonFr BillCarsonFr merged commit 50310d6 into develop Mar 29, 2024
7 of 8 checks passed
@BillCarsonFr BillCarsonFr deleted the valere/udate_analytics_event branch March 29, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants