Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable user mentions in Rich Text Editor #7416

Merged
merged 21 commits into from
Apr 14, 2023
Merged

Enable user mentions in Rich Text Editor #7416

merged 21 commits into from
Apr 14, 2023

Conversation

aringenbach
Copy link
Contributor

@aringenbach aringenbach commented Mar 8, 2023 •
edited
Loading

Fixes #7442

@codecov
Copy link

codecov bot commented Mar 8, 2023 •
edited
Loading

Codecov Report

Patch coverage: 31.35% and project coverage change: +0.03 🎉

Comparison is base (dadeef7) 12.29% compared to head (fbe625f) 12.33%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #7416      +/-   ##
===========================================
+ Coverage    12.29%   12.33%   +0.03%     
===========================================
  Files         1645     1645              
  Lines       163155   163416     +261     
  Branches     66991    67074      +83     
===========================================
+ Hits         20066    20152      +86     
- Misses      142439   142609     +170     
- Partials       650      655       +5
Flag Coverage Δ
uitests 55.23% <61.46%> (-0.02%) ⬇️
unittests 6.21% <13.24%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/Views/RoomInputToolbar/MXKRoomInputToolbarView.m 0.00% <0.00%> (ø)
...iot/Modules/Pills/PillAttachmentViewProvider.swift 0.00% <0.00%> (ø)
Riot/Modules/Room/RoomViewController.m 0.00% <0.00%> (ø)
Riot/Modules/Room/RoomViewController.swift 0.00% <0.00%> (ø)
...les/Room/Views/InputToolbar/RoomInputToolbarView.m 0.00% <0.00%> (ø)
.../WYSIWYGInputToolbar/WysiwygInputToolbarView.swift 0.00% <0.00%> (ø)
...ser/LinkAction/Model/ComposerLinkActionModel.swift 94.73% <0.00%> (-5.27%) ⬇️
...I/Modules/Room/Composer/Model/ComposerModels.swift 85.18% <0.00%> (-4.43%) ⬇️
...estion/Coordinator/UserSuggestionCoordinator.swift 0.00% <0.00%> (ø)
.../Coordinator/UserSuggestionCoordinatorBridge.swift 0.00% <0.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aringenbach aringenbach force-pushed the aringenbach/enable_rte_user_mentions branch 2 times, most recently from 9d91841 to 47375d4 Compare March 22, 2023 15:16
@aringenbach
Enable user mentions in Rich Text Editor
c933526
@aringenbach
Use textDefaultFont in all variants of the InputToolbarView
3b09fcc
@aringenbach
Bump to version 1.2.2
732583e
@aringenbach
Always use preferred font for body
1850299
@aringenbach
Update composer library to 1.3.0 and apply changes
a23987b
@aringenbach
Fix broken constraint after using fullscreen mode
88aac57
@aringenbach
Display user suggestion list in fullscreen mode with shared context f…
5fb426f 
…rom `UserSuggestionCoordinator`
@aringenbach
Use PillProvider for RTE Pills creation
2b61b5b
@aringenbach
Avoid crashing if data source is not ready when translating Pills
9c46f60
@aringenbach
Clean WysiwygInputToolbarView code
5b2ce25
@aringenbach
Allow displaying UserSuggestionList without shadow
7b5a46f
@aringenbach
Fix wrong condition for highlight test
b38ba73
@aringenbach
Update environment object setup and view model context wrapping to re…
052acdd 
…store SwiftUI UI tests
@aringenbach
Bump composer version to 1.4.0
f83599b
@aringenbach
Add changelog
3f9d654
@aringenbach aringenbach force-pushed the aringenbach/enable_rte_user_mentions branch from 1a880ab to 3f9d654 Compare March 23, 2023 16:17
@aringenbach aringenbach marked this pull request as ready for review March 23, 2023 16:25
@aringenbach aringenbach requested review from a team and Anderas and removed request for a team March 23, 2023 16:25
@langleyd langleyd added the Trigger-PR-Build Label to trigger builds for PRs label Mar 24, 2023
@github-actions
Copy link

github-actions bot commented Mar 24, 2023 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/vsPaK5

Anderas
Anderas reviewed Mar 28, 2023
View reviewed changes
Copy link
Contributor

@Anderas Anderas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a relatively large PR so I have a few questions to understand better how the bits are supposed to work together. It would be also useful to cover the behaviour changes with tests where possible

Riot/Modules/MatrixKit/Views/RoomInputToolbar/MXKRoomInputToolbarView.h Outdated Show resolved Hide resolved
Riot/Modules/Pills/PillAttachmentViewProvider.swift Outdated Show resolved Hide resolved
Riot/Modules/Pills/PillsFormatter.swift Show resolved Hide resolved
Riot/Modules/Pills/PillsFormatter.swift Outdated Show resolved Hide resolved
RiotSwiftUI/Modules/Room/UserSuggestion/Service/UserSuggestionServiceProtocol.swift Show resolved Hide resolved
RiotSwiftUI/Modules/Room/Composer/Model/ComposerModels.swift Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Anderas
Anderas approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@Anderas Anderas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the changes

@aringenbach aringenbach merged commit c1a9f31 into develop Apr 14, 2023
@aringenbach aringenbach deleted the aringenbach/enable_rte_user_mentions branch April 14, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langleyd langleyd langleyd left review comments

@Anderas Anderas Anderas approved these changes

Assignees
No one assigned
Labels
Trigger-PR-Build Label to trigger builds for PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Labs: Rich-Text-Editor: Integrate mentions support
3 participants
@aringenbach @Anderas @langleyd