Device Manager: Filter sessions

[paleksandrs]

Closes #6838

Filter menu	Clear filter button	verified sessions screen

PSG-683 ACs:

• Stand-alone other sessions screen has filter icon in the header
• When a filter is active, the filter icon has a green indicator dot
• When a filter is active a filter description is shown at the top of the list
• The filter is cleared when navigating back, meaning it doesn’t affect the ‘Other sessions’ section in the main screen
• The filter is maintained when navigating to a session’s details and returning back to the list
• When no sessions match the filter a ‘no results’ message and clear filter button are shown

[github-actions]

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/F47gRn

[pixlwave]

LGTM! A couple of minor points line.

[pixlwave]

Small personal nitpick: I generally have the attitude that if you need to use a func to create a subview that's probably a code smell and it should likely be extracted out into its own struct.

[codecov]

Codecov Report

Base: 11.58% // Head: 54.13% // Increases project coverage by +42.54% 🎉

Coverage data is based on head (7a7ed56) compared to base (3133317).
Patch coverage: 57.71% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #6860       +/-   ##
============================================
+ Coverage    11.58%   54.13%   +42.54%     
============================================
  Files         1553      410     -1143     
  Lines       154845    16162   -138683     
  Branches     62471     6504    -55967     
============================================
- Hits         17946     8749     -9197     
+ Misses      136292     7218   -129074     
+ Partials       607      195      -412     

Impacted Files	Coverage Δ
...ns/UserOtherSessions/UserOtherSessionsFilter.swift	0.00% <0.00%> (ø)
...ns/UserOtherSessions/UserOtherSessionsModels.swift	100.00% <ø> (ø)
...rSessionsOverview/UserSessionsOverviewModels.swift	100.00% <ø> (ø)
...ssionsOverview/UserSessionsOverviewViewModel.swift	61.90% <0.00%> (ø)
...ons/UserOtherSessions/View/UserOtherSessions.swift	53.57% <43.39%> (-25.85%)	⬇️
...UserOtherSessions/UserOtherSessionsViewModel.swift	63.52% <55.81%> (-17.61%)	⬇️
...herSessions/MockUserOtherSessionsScreenState.swift	100.00% <100.00%> (ø)
...SwiftUI/Modules/Common/Extensions/Collection.swift	0.00% <0.00%> (-100.00%)	⬇️
...odules/Common/Util/ScreenTrackerViewModifier.swift	0.00% <0.00%> (-100.00%)	⬇️
...ice/Mock/MockRoomNotificationSettingsService.swift	0.00% <0.00%> (-100.00%)	⬇️
... and 1175 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[paleksandrs]

@pixlwave thanks for the comments 👍 fixed!