Remove redundancy in heading in bug report issue form #4984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also made the subheadings one size smaller (4 #'s instead of 3)
opusforlife2
commented
Oct 11, 2021
Contributor
Author
opusforlife2
left a comment
opusforlife2
left a comment
There was a problem hiding this comment.
Here's the self review: "Changes seem fine." ... not sure what the point of this is, though?
Contributor
Author
|
@kittykat Hey did you miss the mention notification? |
Contributor
Author
kittykat
suggested changes
Nov 11, 2021
Contributor
I think the intention here is to remind people to look over their commits before submitting the PR, at least to check for typos, whitespace and things like that. |
Contributor
|
@opusforlife2 If you could add a signoff to this PR as well, then IMO it would be ready to merge |
Contributor
|
As per discussion in element-hq/element-android/pull/4257 , merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
This is a follow-up PR to element-hq/element-android#4076. @kittykat Here you go.