key backup: Implement setup screen #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ller and add convenient method to remove back bar button title when pushing a view controller on UINavigationViewController.
…es only `physical` navigation. Add navigation router to handle navigation with UINavigationController.
…trol the navigation flow of the application. Add `Coordinator` base protocol.
…omization and create ActivityIndicatorPresenter in order to manage activity indicator presentation.
…w model, coordinator
…iew model and coordinator
…activity indicator UI in MXKViewController
manuroe
reviewed
Jan 22, 2019
There was a problem hiding this comment.
Can we define an interface for CoordinatorOperations (pauseCoordinatorOperations, resumeCoordinatorOperations, cancelCoordinatorOperations) and a default implementation based on NSOperation?
This is super useful to have but it would be boring to c+p it to each view model we will create from now.
Still about architecture, wdyt about creating interfaces for:
func process(viewAction:)func render(viewState:)(may be harder)
They seem to be a recurrent pattern in this single PR. This will enforce dev to follow that design.
Riot/Modules/Common/ActivityIndicator/ActivityIndicatorPresenterType.swift
Outdated
Show resolved
Hide resolved
Riot/Modules/Common/ActivityIndicator/ActivityIndicatorView.swift
Outdated
Show resolved
Hide resolved
Riot/Modules/Common/KeyboardAvoiding/KeyboardNotification.swift
Outdated
Show resolved
Hide resolved
Riot/Modules/KeyBackup/Setup/RecoveryKey/KeyBackupSetupRecoveryKeyViewModel.swift
Outdated
Show resolved
Hide resolved
Co-Authored-By: SBiOSoftWhare <[email protected]>
Co-Authored-By: SBiOSoftWhare <[email protected]>
Co-Authored-By: SBiOSoftWhare <[email protected]>
…SetupRecoveryKeyViewModel
…e coordinator delegation in an operation queue.
…to handle coordinator delegation in an operation queue." This reverts commit 01bc067.
manuroe
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2192