Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of Obj-C's modern syntax for literals and subscripting #2160

Merged
merged 5 commits into from
Jan 10, 2019
Merged

Make use of Obj-C's modern syntax for literals and subscripting #2160

merged 5 commits into from
Jan 10, 2019

Conversation

fridtjof
Copy link
Contributor

@fridtjof fridtjof commented Jan 7, 2019

Signed-off-by: Fridtjof Mund [email protected]

@fridtjof
Copy link
Contributor Author

fridtjof commented Jan 9, 2019

Should this change be under 0.7.11 or a new "unreleased" section in CHANGES.rst?

manuroe
manuroe approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@manuroe manuroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge thanks @fridtjof for making the code more readable.
I guess matrix-ios-sdk & matrix-ios-kit would love such update ;)

@manuroe
Copy link
Member

manuroe commented Jan 10, 2019

Should this change be under 0.7.11 or a new "unreleased" section in CHANGES.rst?
In a new section. I updated it while resolving the merge conflict.

@manuroe manuroe merged commit be674de into element-hq:develop Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morozkin morozkin morozkin left review comments

@manuroe manuroe manuroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fridtjof @manuroe @morozkin