Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room screen: Tap on attached video does nothing #380

Closed
giomfo opened this issue Jun 10, 2016 · 2 comments
Closed

Room screen: Tap on attached video does nothing #380

giomfo opened this issue Jun 10, 2016 · 2 comments
Labels
P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@giomfo
Copy link
Member

giomfo commented Jun 10, 2016

To reproduce:

  • attach a video in a chat room
  • at the end of ther sending process, tap on the resulting outgoing bubble: nothing happens NOK
@giomfo giomfo added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems P1 labels Jun 10, 2016
giomfo added a commit to matrix-org/matrix-ios-kit that referenced this issue Jun 10, 2016
@giomfo
Bug Fix:Room screen: Tap on attached video does nothing
8de1c1c 
element-hq/element-ios#380
@giomfo giomfo mentioned this issue Jun 10, 2016
Merged
@giomfo giomfo closed this as completed Jun 10, 2016
@AndrewJDR
Copy link

Tapping on an attached video still doesn't seem to do anything for me, even in a build of the latest vector-ios develop branch. Is this expected?

@giomfo
Copy link
Member Author

giomfo commented Jun 22, 2016

AndrewJDR: This is not expected. Tap on attached video should work correctly now.

Did you clear cache since you updated the app?
Could you provide us a scenario to reproduce your issue?

langleyd pushed a commit that referenced this issue Mar 29, 2023
@jonnyandrew
Change link interface to use string (#380)
70a0e50 
Update the interface for link actions to use `String` instead of `Vec<u16>` so that the Kotlin/Swift bindings generated for this class use the native string types and do not need conversion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndrewJDR @giomfo