Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It's too hard to press names to auto-insert nicks #309

Closed
matrixbot opened this issue May 9, 2016 · 3 comments
Closed

It's too hard to press names to auto-insert nicks #309

matrixbot opened this issue May 9, 2016 · 3 comments
Assignees
@giomfo
Labels
P1 T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@matrixbot
Copy link

Created by @ matthew:matrix.org.

Plus many messages have no name that can be tapped (e.g. m.emotes). Either we need to make the hit zone bigger and more consistent, or go back to using the avatar (and making sure that avatar long-tap takes you to the member info page)
giomfo added a commit that referenced this issue May 13, 2016
@giomfo
Bug Fix: It's too hard to press names to auto-insert nicks.
9ba885e 
Go back to using the avatar (and making sure that avatar long-tap takes you to the member info page)

#309
@giomfo giomfo closed this as completed May 13, 2016
@giomfo giomfo reopened this May 13, 2016
@giomfo giomfo closed this as completed May 13, 2016
@AmandineLP
Copy link

AmandineLP commented May 13, 2016 •
edited
Loading

@ara4n I don't agree: long press for user info is too hidden. I'm happy to increase the zone though. And I don't think that emotes are a real issue as people can find avatars not far away, or in the user info #317 when implemented.

@AmandineLP AmandineLP reopened this May 13, 2016
@giomfo
Copy link
Member

giomfo commented May 13, 2016

After discussion, we plan to implement the current Android behaviour:

  • Tap on name: auto-insert nickname (For that we have to increase hit zone).
  • Tap avatar: go to member info page
  • Long press on avatar: auto-insert nickname (this solves the emotes case)

@giomfo giomfo added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements P1 labels May 13, 2016
@ara4n
Copy link
Member

ara4n commented May 13, 2016

wfm

@giomfo giomfo assigned giomfo and unassigned ara4n May 17, 2016
giomfo added a commit to matrix-org/matrix-ios-kit that referenced this issue May 17, 2016
@giomfo
BugFix: It's too hard to press names to auto-insert nicks
c5bb0ed 
element-hq/element-ios#309
@giomfo giomfo mentioned this issue May 17, 2016
Merged
giomfo added a commit that referenced this issue May 17, 2016
@giomfo
BugFix: It's too hard to press names to auto-insert nicks.
5c50421 
#309
@giomfo giomfo mentioned this issue May 17, 2016
Merged
@giomfo giomfo closed this as completed May 17, 2016
langleyd pushed a commit that referenced this issue Mar 29, 2023
@Half-Shot
Fix live demo link (#309)
6ac5532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giomfo giomfo

Labels
P1 T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ara4n @AmandineLP @giomfo @matrixbot