Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send IS for adding MSISDNs only when required by HS #2682

Closed
jryans opened this issue Aug 30, 2019 · 0 comments
Closed

Send IS for adding MSISDNs only when required by HS #2682

jryans opened this issue Aug 30, 2019 · 0 comments
Assignees
@manuroe
Labels
A-Identity-Server feature privacy privacy-sprint T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@jryans
Copy link
Contributor

jryans commented Aug 30, 2019

Cloned from element-hq/element-web#10599

Similar to email handing, MSC2263 records that m.require_identity_server will return a boolean that applies to both email and MSISDN cases.

Earlier in the project, it was unclear what would happen for MSISDN cases. As of this task, we we will only supply an IS to the HS in the following paths:

  • Registration with MSISDN, but do not send if m.require_identity_server exists and is false
  • Adding MSISDN to HS account, but do not send if m.require_identity_server exists and is false
  • Binding MSISDN for discovery (request proxied via HS, always send IS)

This should match the behaviour with email.
@jryans jryans changed the title Send IS for adding MSISDNs only when required by HS Send IS for adding MSISDNs only when required by HS Aug 30, 2019
@manuroe manuroe self-assigned this Sep 9, 2019
manuroe added a commit that referenced this issue Sep 9, 2019
@manuroe
Send IS for adding MSISDNs only when required by HS
6f71f60 
#2682
manuroe added a commit that referenced this issue Sep 11, 2019
@manuroe
Send IS for adding MSISDNs only when required by HS
d6f0c6e 
#2682
manuroe added a commit that referenced this issue Sep 11, 2019
@manuroe
Send IS for adding MSISDNs only when required by HS
82af540 
#2682
@manuroe manuroe mentioned this issue Sep 11, 2019
Merged
@manuroe manuroe closed this as completed Sep 11, 2019
@kittykat kittykat added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
A-Identity-Server feature privacy privacy-sprint T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kittykat @jryans @manuroe