Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Share Extension] Handle rich item sharing (image + text + URL) #2224

Closed
SBiOSoftWhare opened this issue Feb 5, 2019 · 1 comment · Fixed by #2234
Closed

[Share Extension] Handle rich item sharing (image + text + URL) #2224

SBiOSoftWhare opened this issue Feb 5, 2019 · 1 comment · Fixed by #2234
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@SBiOSoftWhare
Copy link
Contributor

Use case:

  • Choose an app on the App Store.
  • Share with Riot.
  • Three items are received with types: public.image, public.plain-text, public.url.
  • Only two of them are received in the room: public.plain-text and public.url.
@SBiOSoftWhare SBiOSoftWhare added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Feb 5, 2019
@SBiOSoftWhare
Copy link
Contributor Author

SBiOSoftWhare commented Feb 6, 2019 •
edited
Loading

-[NSExtensionContext completeRequestReturningItems] is called multiple times when sharing items of different type. As background upload is not yet supported by the share extension -[NSExtensionContext completeRequestReturningItems] should be called (to dismiss the share extension) when all items have been uploaded.

SBiOSoftWhare added a commit that referenced this issue Feb 8, 2019
@SBiOSoftWhare
[Share extension] Support rich item sharing (e.g. URL + text + image)…
c2f7881 
…. Fix issue #2224.
@SBiOSoftWhare SBiOSoftWhare mentioned this issue Feb 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BF: [Share Extension] Handle rich item sharing (image + text + URL) element-hq/element-ios
1 participant
@SBiOSoftWhare