Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in [MXKEventFormatter renderHTMLString:forEvent:] on 0.7.6 #2080

Closed
manuroe opened this issue Oct 16, 2018 · 2 comments
Closed

Crash in [MXKEventFormatter renderHTMLString:forEvent:] on 0.7.6 #2080

manuroe opened this issue Oct 16, 2018 · 2 comments
Labels
crash P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Milestone
Sprint 14

Comments

@manuroe
Copy link
Member

manuroe commented Oct 16, 2018

Reported at https://matrix.to/#/!DdJkzRliezrwpNebLk:matrix.org/$15396563361781LnhXR:matrix.ordoevangelistarum.com.

Rageshake available.
@manuroe manuroe added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems P1 crash labels Oct 16, 2018
@manuroe manuroe added this to the Sprint 14 milestone Oct 16, 2018
@manuroe
Copy link
Member Author

manuroe commented Oct 17, 2018

https://matrix.to/#/!ZrZoyXEyFrzcBZKNis:matrix.org/$15397144342292656Rkoxi:matrix.org contains a bad formatted m.relates_to value:

    "m.relates_to": [
      "m.in_reply_to",
      {
        "event_id": "$15397143222292107tZTHu:matrix.org"
      }
    ]

manuroe added a commit to matrix-org/matrix-ios-kit that referenced this issue Oct 17, 2018
@manuroe
MXKEventFormatter: Be robust on malformatted m.relates_to data content
94002e1 
element-hq/element-ios/issues/2080
@manuroe manuroe mentioned this issue Oct 17, 2018
Merged
jgkamat added a commit to alphapapa/matrix-client.el that referenced this issue Oct 17, 2018
@jgkamat
Attempt to fix malformed replys
0e3bef5 
See element-hq/element-ios#2080

Not fully tested yet, so feel free to revert.
@alphapapa
Copy link

Thanks for fixing this, and my apologies for sending the malformed events.

This makes me wonder how many similar bugs are lurking in a variety of clients. It could be trivial to cause DoS crashes by sending slightly malformed events. I can't even run Riot on iOS right now because I'm in some rooms with the malformed events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crash P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
Sprint 14
Development

No branches or pull requests
2 participants
@alphapapa @manuroe