Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build on 32 bit Windows #23

Merged
merged 6 commits into from
Feb 19, 2020
Merged

Build on 32 bit Windows #23

merged 6 commits into from
Feb 19, 2020

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Feb 19, 2020

A pleasingly small diff to support targeting 32 bit Windows.

Unfortunately also requires neon-bindings/neon#491, so will require:

  • That PR to be merged
  • Neon to be released
  • neon-serde to release a new version that's compatible with neon 0.4.x
  • matrix-seshat to update versions of both the above

@dbkr dbkr requested a review from a team February 19, 2020 10:10
jryans
jryans approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems relatively sane! 😅

@dbkr dbkr merged commit 050501b into master Feb 19, 2020
@t3chguy t3chguy deleted the dbkr/hak_win_x86 branch May 3, 2022 09:57
@rda0 rda0 mentioned this pull request Aug 25, 2023
Closed
@Half-Shot Half-Shot mentioned this pull request May 20, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbkr @jryans