Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor media auth redirects to not kick in if the user is not logged in #1817

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Refactor media auth redirects to not kick in if the user is not logged in #1817

merged 1 commit into from
Aug 7, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Aug 6, 2024

Fixes #1814

@t3chguy t3chguy self-assigned this Aug 6, 2024
@t3chguy t3chguy marked this pull request as ready for review August 6, 2024 15:13
@t3chguy t3chguy requested a review from a team as a code owner August 6, 2024 15:13
@dosubot dosubot bot added the T-Task Tasks for the team like planning label Aug 6, 2024
dbkr
dbkr approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. If I'm being nitpicky I'd say next time it would be easier to read (and easier to prove correct) wit the refactor in a separate PR/commit to the fix... but mostly I'm just grateful for the refactor.

@t3chguy t3chguy merged commit 6fca680 into develop Aug 7, 2024
41 checks passed
@t3chguy t3chguy deleted the t3chguy/fix/d1814 branch August 7, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Defect T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSO Icon does not show on the login page, error 401 Internal Redirect after updating to 1.11.72
2 participants
@t3chguy @dbkr