Switch to the new session API for screen-sharing
#1081
Conversation
See electron/electron#30702 - this has the benefit of the js-sdk and LiveKit not having to add custom logic for Electron Signed-off-by: Šimon Brandner <[email protected]>
| await getDisplayMediaCallback()?.({ video: args[0] }); | ||
| setDisplayMediaCallback(null); |
There was a problem hiding this comment.
Not a fan of this but don't have suggestions to improve it :D
There was a problem hiding this comment.
Hah, yeah, I also managed to disgust myself but wasn't sure how to fix it. (that could also described me making my first pizza)
|
Probably nothing we can do about it but I noticed this causing unhandled type errors because some people appear to still run ED using an earlier version of Electron: https://sentry.tools.element.io/organizations/element/issues/83867/events/latest/?project=6&query=release%3AElement-Nightly%402023102401+error.unhandled%3Atrue&referrer=latest-event&sort=freq&stream_index=4 |
|
@Johennes we don't support using Element Desktop with any Electron version other than the one present in yarn.lock at the time. It is a known issue with some community-maintained packages which rely on a system Electron binary which lags behind. |
|
Right, yeah. I've already added the fact that we capture this in Sentry to begin with to the list of problems in https://github.com/vector-im/wat-internal/issues/60. Just meant to cross-post here. |
See electron/electron#30702 - this has the benefit of the js-sdk and LiveKit not having to add custom logic for Electron
Fixes element-hq/element-call#1242
Requires element-hq/element-web#25802
Requires matrix-org/matrix-react-sdk#11266
This change is marked as an internal change (Task), so will not be included in the changelog.