-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video tile redesign/refactor #1989
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## livekit #1989 +/- ##
========================================
Coverage 25.02% 25.02%
========================================
Files 48 47 -1
Lines 2394 2382 -12
Branches 438 434 -4
========================================
- Hits 599 596 -3
+ Misses 1744 1735 -9
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3290b44
to
2d894b8
Compare
2d894b8
to
b2bc8ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
This is super satisfying to see how this also makes it a lot more readable (+ better to test)
Most of the code also was very striaght forward to review.
Playing around with it I found the following, is this intentional?
- The user tile ("you") cannot be moved into the first position grid mode.
I will give this a approval since I am on holiday but before merging I think the "cannot be moved into the first position" should addressed (exept its by design. If so I would be curious why) and the TODO (move to vm in case that is easy enough for this PR)
Ah right, I've seen this happening in the application for some months, so I don't believe it's a regression introduced here. The plan for fixing this is that, the new grid layouts won't allow for dragging and dropping anyways, so I'd like to move ahead with implementing them. |
Depends on element-hq/compound-web#110
Closes #1764
Fixes one half of #1839 (local video is now mirrored correctly in the call view, but not in the lobby)