Fix QR code login support in rust #8654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giomfo
added
the
Z-NextRelease
bmarty
approved these changes
Oct 3, 2023
Member
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
LGTM, some non-blocking remarks/questions.
...k-android/src/kotlinCrypto/java/org/matrix/android/sdk/internal/crypto/SecretShareManager.kt
Show resolved
Hide resolved
...k-android/src/kotlinCrypto/java/org/matrix/android/sdk/internal/crypto/SecretShareManager.kt
Outdated
Show resolved
Hide resolved
...k-android/src/kotlinCrypto/java/org/matrix/android/sdk/internal/crypto/SecretShareManager.kt
Show resolved
Hide resolved
| it.requestSecret(USER_SIGNING_KEY_SSSS_NAME, verifyingDeviceId) | ||
| it.requestSecret(KEYBACKUP_SECRET_SSSS_NAME, verifyingDeviceId) | ||
| } | ||
| session.sharedSecretStorageService().requestMissingSecrets() |
Member
There was a problem hiding this comment.
I understand that we request the secrets from all our devices, and not the device which was used to verify (verifyingDeviceId). I think it's fine, but maybe update the comment and the log above?
...sdk-android/src/rustCrypto/java/org/matrix/android/sdk/internal/crypto/SecretShareManager.kt
Show resolved
Hide resolved
...ain/java/org/matrix/android/sdk/internal/crypto/secrets/DefaultSharedSecretStorageService.kt
Show resolved
Hide resolved
vector/src/test/java/im/vector/app/test/fakes/FakeSharedSecretStorageService.kt
Show resolved
Hide resolved
…k/internal/crypto/SecretShareManager.kt Co-authored-by: Benoit Marty <[email protected]>
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Fixes #8653
Depends on new rust sdk matrix-org/matrix-rust-sdk#2632
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist