Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y fixes #8426

Merged
merged 9 commits into from
May 15, 2023
Merged

A11y fixes #8426

merged 9 commits into from
May 15, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 11, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

This PR improve the behavior of the application regarding accessibility.

  • It fixes some bugs observed when navigating with the keyboard (using arrows and tab).
  • It also improves behavior when the screen reader is active, by given accessibility focus on Alert displayed on top of the screen, such as verification request, or incoming phone call.
  • On the Alert it adds a custom action to let visually impaired users discover how to close the alert (there is no close button, user has to laterally swipe the alert).
  • Content description of avatar has been updated to give more info when the screen reader is one.

Motivation and context

Screenshots / GIFs

Tests

  • Navigate into the app using the keyboard. For instance, in the room search screen, it was not possible to navigate from the toolbar to the room list and extra action at the bottom for instance. Now it's possible
    Note: In the room list, you can navigate to the top of the screen, and to enter in the toolbar content, user must press on "Tab" (twice)
  • Enable screen reader from the accessibility setting of the phone and start a verification flow. Screen reader should focus and read the first item on each new step, to let user know that a new step is displayed. There are some glitch here, sometimes the last item is focused.

Note: all those changes should not have any impact if no keyboard is connected to the device, nor if no screen reader is enabled.

Tested devices

  • Physical, using Vysor as a gateway to control the device with the keyboard of the computer.
  • Emulator
  • OS version(s):

Checklist

@element-hq element-hq deleted a comment from ElementBot May 11, 2023
@bmarty bmarty marked this pull request as ready for review May 11, 2023 12:46
@bmarty bmarty requested review from a team and jmartinesp and removed request for a team May 11, 2023 12:46
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
4.2% 4.2% Duplication

@bmarty
Copy link
Member Author

bmarty commented May 15, 2023

Merging the pull request, since it fixes the a11y issues.

Note: during the tests, we have found this issue, which is not new, and should not block this PR from being merged.

@bmarty bmarty merged commit 7c3ecec into develop May 15, 2023
@bmarty bmarty deleted the feature/bma/a11yFixes branch May 15, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant