Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rich text editor] Fix code appearance #8171

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Feb 24, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Fix issue where inline code does not display with the correct background color if the system theme is different to the theme selected in the in-app settings.

Motivation and context

Fixes vector-im/verticals-internal#23

Screenshots / GIFs

Light in-app, dark system Dark in-app, light system Black in-app, light system
light dark black

Tests

  • Go to the in-app settings and enable the light theme
  • Go to the system settings and enable dark mode
  • (or vice-versa)
  • Enable the rich text editor
  • Compose code in the rich text editor
  • Note the background of the code
  • Send the code to the room
  • Note the background of the code in the timeline

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 13

Checklist

Code does not use the correct theme colour when the theme is manually
selected in the app settings.

https://github.com/vector-im/verticals-internal/issues/23
@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonnyandrew jonnyandrew marked this pull request as ready for review February 24, 2023 17:09
@jonnyandrew jonnyandrew requested review from a team and jmartinesp and removed request for a team February 24, 2023 17:09
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonnyandrew jonnyandrew merged commit 39d9591 into develop Feb 27, 2023
@jonnyandrew jonnyandrew deleted the jonny/fix/code-color branch February 27, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants