Skip to content

Bump fragment from 1.6.0-alpha04 to 1.6.0-alpha06 #8165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yostyle merged 3 commits into from
Mar 8, 2023
Merged

Bump fragment from 1.6.0-alpha04 to 1.6.0-alpha06 #8165

yostyle merged 3 commits into from
Mar 8, 2023

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 22, 2023

Bumps fragment from 1.6.0-alpha04 to 1.6.0-alpha06.
Updates androidx.fragment:fragment-ktx from 1.6.0-alpha04 to 1.6.0-alpha06

Updates androidx.fragment:fragment-testing from 1.6.0-alpha04 to 1.6.0-alpha06

Updates androidx.fragment:fragment-testing-manifest from 1.6.0-alpha04 to 1.6.0-alpha06

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Feb 22, 2023
@dependabot dependabot bot requested review from a team and yostyle and removed request for a team February 22, 2023 23:15
@dependabot dependabot bot mentioned this pull request Feb 22, 2023
Closed
@dependabot dependabot bot requested a review from jonnyandrew February 22, 2023 23:15
@yostyle yostyle requested a review from a team March 2, 2023 13:39
@yostyle yostyle self-assigned this Mar 2, 2023
@yostyle yostyle requested review from a team and removed request for a team and yostyle March 2, 2023 13:40
@yostyle yostyle marked this pull request as draft March 2, 2023 14:37
@yostyle yostyle force-pushed the dependabot/gradle/fragment-1.6.0-alpha06 branch from 3ca6f6e to cf79366 Compare March 2, 2023 14:39
@yostyle yostyle marked this pull request as ready for review March 2, 2023 14:40
@yostyle yostyle enabled auto-merge (squash) March 3, 2023 13:23
@bmarty bmarty requested review from a team, bmarty and ganfra and removed request for a team, ganfra and jonnyandrew March 3, 2023 14:19
@bmarty
Copy link
Member

bmarty commented Mar 6, 2023

(I have merged develop on this branch to try to fix the failing test)

dependabot bot and others added 3 commits March 7, 2023 14:23
@dependabot @yostyle
Bump fragment from 1.6.0-alpha04 to 1.6.0-alpha06
766ecf5 
Bumps `fragment` from 1.6.0-alpha04 to 1.6.0-alpha06.

Updates `androidx.fragment:fragment-ktx` from 1.6.0-alpha04 to 1.6.0-alpha06

Updates `androidx.fragment:fragment-testing` from 1.6.0-alpha04 to 1.6.0-alpha06

Updates `androidx.fragment:fragment-testing-manifest` from 1.6.0-alpha04 to 1.6.0-alpha06

---
updated-dependencies:
- dependency-name: androidx.fragment:fragment-ktx
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: androidx.fragment:fragment-testing
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: androidx.fragment:fragment-testing-manifest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@yostyle
Replace deprecated methods
2a13370
@yostyle
Fix tests
aeadf24
@yostyle yostyle force-pushed the dependabot/gradle/fragment-1.6.0-alpha06 branch from 4170da2 to aeadf24 Compare March 7, 2023 13:23
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@yostyle yostyle removed their assignment Mar 8, 2023
bmarty
bmarty approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yostyle yostyle merged commit ea6279e into develop Mar 8, 2023
@yostyle yostyle deleted the dependabot/gradle/fragment-1.6.0-alpha06 branch March 8, 2023 16:58
@bagvand
Copy link

bagvand commented May 3, 2023 •
edited
Loading

Hi,
These changes contain a bug.
secure backup is mandatory in my server
when a new user register in the app then a dialog of setting secure backup will be apears. after setting secure backup then go to privacy setting and then back to home then you will see new undismissable dialog below
Screenshot_20230503-163332_Element

you must close app then open again to use it.

@bmarty
@yostyle
Please test these changes for a user register with mandatory secure backup .

Also sometime the secure backup will repeat two time!

@bagvand
Copy link

bagvand commented May 3, 2023 •
edited
Loading

I think we must use
lifecycleScope.launch { lifecycle.withResumed { } }
in some place instead of
lifecycleOwner.repeatOnLifecycle(Lifecycle.State.RESUMED)

the first one will be execute once but second will execute every time that RESUME.
@bmarty
@yostyle

@bagvand
Copy link

bagvand commented May 3, 2023

It is look like that google doc is wrong and
launchWhenResumed != repeatOnLifecycle(Lifecycle.State.RESUMED)

and true is:
launchWhenResumed = launch { lifecycle.withResumed { } }

because repeatOnLifecycle(Lifecycle.State.RESUMED) will be repeat and launch { lifecycle.withResumed { } } will not.

bmarty added a commit that referenced this pull request May 9, 2023
@bmarty
Do not repeat the recovery setup.
9569c34 
Should fix issue reported at #8165 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmarty bmarty bmarty approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bmarty @bagvand @yostyle