Fix always jumps to the bottom of the timeline #8090 #8152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganfra
added
the
Z-NextRelease
jmartinesp
approved these changes
Feb 21, 2023
ganfra
force-pushed
the
feature/fga/fix_timeline_position_loss
branch
from
382abdc
to
84cb6e7
Compare
|
Kudos, SonarCloud Quality Gate passed! |
bmarty
reviewed
Feb 27, 2023
| @@ -1038,7 +1039,6 @@ class TimelineFragment : | |||
| timelineEventController.callback = this | |||
| timelineEventController.timeline = timelineViewModel.timeline | |||
|
|
|||
| views.timelineRecyclerView.trackItemsVisibilityChange() | |||
There was a problem hiding this comment.
I am wondering if this extension is correct since we never detach the tracker...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8090
The regression came from this #7734
I've checked it was still fixing the related notification issue ^