Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

element-hq / element-android Public

Notifications You must be signed in to change notification settings
Fork 731
Star 3.4k

Code
Issues 2.1k
Pull requests 32
Actions
Projects 1
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded color on send button #8142

Merged

bmarty merged 2 commits into develop from yostyle/fix_sendbutton_color

Feb 17, 2023

Merged

Remove hardcoded color on send button #8142

bmarty merged 2 commits into develop from yostyle/fix_sendbutton_color

Feb 17, 2023

Conversation 2 Commits 2 Checks 0 Files changed

Conversation

Copy link

Contributor

yostyle commented Feb 17, 2023

Type of change

Feature
Bugfix
Technical
Other :

Content

Send button background color is hardcoded. Now we use the theming colors instead.

Screenshots / GIFs

Tests

Step 1
Step 2
Step ...

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

Sorry, something went wrong.

All reactions


          Remove hardcoded color on send button

835e1f5

yostyle requested review from jmartinesp and bmarty

February 17, 2023 10:21


          Add changelog

4c12c0d

jmartinesp approved these changes

View reviewed changes

Copy link

Member

jmartinesp left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

All reactions

bmarty removed their request for review

February 17, 2023 10:35

yostyle enabled auto-merge

February 17, 2023 10:37

Copy link

sonarcloud bot commented Feb 17, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

All reactions

Sorry, something went wrong.

bmarty disabled auto-merge

February 17, 2023 14:53

bmarty merged commit 386814e into develop

bmarty deleted the yostyle/fix_sendbutton_color branch

February 17, 2023 14:53

jdauphant mentioned this pull request

Remove hardcoded color on save button #8208

Merged

15 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jmartinesp jmartinesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2024 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.