Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Poll] Improve rendering of poll end message when poll start event isn't available (PSG-1157) #8136

Merged
merged 4 commits into from
Feb 17, 2023

Conversation

mnaturel
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Add a special rendering for the message when receiving a poll End event while the related poll start is not available in the timeline.
Send a fallback text in the poll end event (may be needed by other Matrix clients).

Motivation and context

Closes #8129

Screenshots / GIFs

Tests

  • Create a new room
  • Set the setting in the room so that new joiners cannot see the history
  • Create a poll
  • Invite another user
  • Wait for the user to join
  • End the previously created poll
  • Check the other user sees a simple "Poll ended" message without any other info

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel marked this pull request as ready for review February 15, 2023 09:49
@mnaturel mnaturel requested review from a team and yostyle and removed request for a team February 15, 2023 09:49
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

8.3% 8.3% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnaturel mnaturel merged commit de50577 into develop Feb 17, 2023
@mnaturel mnaturel deleted the fix/mna/poll-end-while-no-poll-start branch February 17, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Poll] Improve rendering of poll end message when poll start event isn't available
2 participants