Feature/msc 2192 #810
Merged
Feature/msc 2192 #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
force-pushed
the
feature/msc_2192
branch
from
b4c6e78
to
918f911
Compare
|
Really nice! Would we be able to see who voted for what, or is this pseudo-anonymous (because we see the read markers)? |
bmarty
force-pushed
the
feature/msc_2192
branch
from
6f9ef5e
to
9016688
Compare
bmarty
approved these changes
Feb 12, 2020
There was a problem hiding this comment.
LGTM. I'll create issue for what is missing.
@BillCarsonFr if you agree with my commit, you can merge!
This was referenced Feb 12, 2020
Closed
It's not anonymous as per spec. No UX yet to show votes (but soon -> #996) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#See matrix-org/matrix-spec-proposals#2192
Pull Request Checklist