Skip to content

Conversation

@bmarty
Copy link
Member

@bmarty bmarty commented Jan 27, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Ensure sync thread is started when the app recover from a crash or from a process killed by the system.

Motivation and context

See message coming when using the app.
Closes #8010

Also fixing a rendering issue when messages fail to be sent:

image

  • Adding a /crash command, only auto-completed (and active) when in developer mode to crash the app and provokate a recovery.

Screenshots / GIFs

Before After
StoppedSyncBefore StoppedSyncAfter

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Jan 27, 2023
@bmarty bmarty requested review from a team, Florian14 and ganfra and removed request for a team January 27, 2023 16:17
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@Florian14 Florian14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

private fun initialize() {
if (isInitialized) return
isInitialized = true
// Ensure Session is syncing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment really useful? Not an issue at all

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, a bit useless. I added the comment when the use case had another name. Could be removed now (but I will not trigger the CI for that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-NextRelease For issues and PRs which should be included in the NextRelease.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The app stops recieving new messages until I restart it

4 participants