Skip to content

Send voice message should not be allowed during a voice broadcast recording #7974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yostyle merged 2 commits into from
Jan 20, 2023
Merged

Send voice message should not be allowed during a voice broadcast recording #7974

yostyle merged 2 commits into from
Jan 20, 2023

Conversation

@yostyle
Copy link
Contributor

@yostyle yostyle commented Jan 19, 2023

@yostyle yostyle added A-Voice-Messages A-Voice Broadcast Broadcast-style voice messages labels Jan 19, 2023
@jmartinesp
Copy link
Member

jmartinesp commented Jan 19, 2023

Should we also consider the case when the voice broadcast is paused, you start a voice message and lock it so it keeps recording, then resume the broadcast? I think both recordings will be running at the same time.

Grabacion.de.pantalla.2023-01-19.a.las.12.09.54.mov

@giomfo
Copy link
Member

giomfo commented Jan 20, 2023

Should we also consider the case when the voice broadcast is paused, you start a voice message and lock it so it keeps recording, then resume the broadcast? I think both recordings will be running at the same time.

Yes we should block voice message even when voice broadcast is paused

jmartinesp
jmartinesp requested changes Jan 20, 2023
View reviewed changes
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on @giomfo 's comment, I think we need to add some extra checks to prevent voice broadcasts and voice messages from running at the same time.

@yostyle yostyle requested a review from jmartinesp January 20, 2023 14:31
@yostyle yostyle added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Jan 20, 2023
jmartinesp
jmartinesp approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@yostyle yostyle merged commit 64f9cfe into develop Jan 20, 2023
@yostyle yostyle deleted the yosyle/voicebroadcast_block_voicemessage branch January 20, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmartinesp jmartinesp jmartinesp approved these changes

@Florian14 Florian14 Awaiting requested review from Florian14

Assignees

No one assigned

Labels

A-Voice Broadcast Broadcast-style voice messages A-Voice-Messages Z-NextRelease For issues and PRs which should be included in the NextRelease.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yostyle @jmartinesp @giomfo