Skip to content

Voice Broadcast - Fix playback scrubbing not working if playback is stopped #7963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Florian14 merged 1 commit into from
Jan 23, 2023
Merged

Voice Broadcast - Fix playback scrubbing not working if playback is stopped #7963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/7961.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Voice Broadcast - Fix playback scrubbing not working if the playback is in a stopped state
19 changes: 10 additions & 9 deletions ...src/main/java/im/vector/app/features/voicebroadcast/listening/VoiceBroadcastPlayerImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,15 +182,16 @@ class VoiceBroadcastPlayerImpl @Inject constructor(
}
}
State.Buffering -> {
val nextItem = if (isLiveListening && playlist.currentSequence == null) {
// live listening, jump to the last item if playback has not started
playlist.lastOrNull()
} else {
// not live or playback already started, request next item
playlist.getNextItem()
}
if (nextItem != null) {
startPlayback(nextItem.startTime)
val savedPosition = currentVoiceBroadcast?.voiceBroadcastId?.let { playbackTracker.getPlaybackTime(it) }
when {
// resume playback from the next sequence item
playlist.currentSequence != null -> playlist.getNextItem()?.let { startPlayback(it.startTime) }
// resume playback from the saved position, if any
savedPosition != null -> startPlayback(savedPosition)
// live listening, jump to the last item
isLiveListening -> playlist.lastOrNull()?.let { startPlayback(it.startTime) }
// start playback from the beginning
else -> startPlayback(0)
}
}
is State.Error -> Unit
Expand Down