Skip to content

Conversation

@Florian14
Copy link
Contributor

Type of change

  • WIP Feature
  • Bugfix
  • Technical
  • Other :

Content

During the handling of the notifications, notify only the first voice chunk of a voice broadcast, and ignore the other events related to the voice broadcast chunks

Motivation and context

Close #7845

Screenshots / GIFs

vb_notifications.mp4

Tests

  • Enable all notifications on Android device
  • Start a voice broadcast from another device
  • Pause or wait 2 min to send a chunk
  • Verify that a voice broadcast notification appears on Android device
  • Resume & Pause again the VB or wait for a second chunk
  • Verify that there is no new notification
  • Verify that the other notifications (text or simple voice message) are still working

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@Florian14 Florian14 requested review from a team and jonnyandrew and removed request for a team January 12, 2023 17:17
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

5.7% 5.7% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@jonnyandrew jonnyandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Florian14 Florian14 merged commit 1b192ea into develop Jan 13, 2023
@Florian14 Florian14 deleted the feature/fre/vb_notification_on_first_chunk branch January 13, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore the voice broadcast chunks at the notifications level

3 participants