New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reply to threaded push notification now sent to thread #7805

Merged

fedrunov merged 1 commit into develop from feature/nfe/thread_push_quick_reply

Dec 20, 2022

Contributor

fedrunov commented Dec 16, 2022

Type of change

Feature
Bugfix
Technical
Other :

Content

Currently reply to push notification of threaded messages goes to main timeline instead of thread

Motivation and context

closes #7475

Screenshots / GIFs

Tests

Step 1
Step 2
Step ...

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()


          reply to threaded push notification now sent to thread not to main ti…

115e95c

…meline

fedrunov requested a review from a team

December 16, 2022 09:29

ElementBot commented Dec 16, 2022

	Warnings
⚠️	Please add a reviewer to your PR.

Generated by 🚫 dangerJS against 115e95c

fedrunov requested review from a team and jonnyandrew and removed request for a team

December 16, 2022 09:32

jonnyandrew approved these changes

View reviewed changes

sonarcloud bot commented Dec 20, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

fedrunov merged commit f4dca57 into develop

fedrunov deleted the feature/nfe/thread_push_quick_reply branch

December 20, 2022 12:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet