Skip to content

Conversation

@mnaturel
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

In the other sessions list screen, when long pressing a session item, toggle selection of this item even in selection mode.

Motivation and context

Closes #7792

Screenshots / GIFs

Tests

  • Enable the labs setting for new session manager
  • Go to Settings -> Security & Privacy -> Show all sessions
  • Press the View all button in the other sessions list (need more than 5 other sessions)
  • Long press one session to enable the selection mode
  • Long press another session
  • Check it select this other session
  • Long press a selected session
  • Check it un-select the pressed session

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel marked this pull request as ready for review December 15, 2022 13:44
@mnaturel mnaturel requested review from a team and onurays and removed request for a team December 15, 2022 13:44
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mnaturel mnaturel added the PR-Small PR with less than 20 updated lines label Dec 16, 2022
@mnaturel mnaturel requested review from a team and ganfra and removed request for a team and onurays December 19, 2022 08:25
Copy link
Contributor

@onurays onurays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mnaturel mnaturel merged commit b609c5c into develop Dec 19, 2022
@mnaturel mnaturel deleted the fix/mna/long-press-select-in-other-sessions branch December 19, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Small PR with less than 20 updated lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Session Manager] Other sessions list: cannot select/deselect session by a long press when in select mode

3 participants