[Session manager] Sessions without encryption support should not prompt to verify (PSG-1004) #7736

mnaturel · 2022-12-07T15:12:34Z

Type of change

Feature
Bugfix
Technical
Other :

Content

Render a specific UI in session manager screens (main screen and session overview screen) when a session does not support encryption.

Motivation and context

Closes #7733
See also element-hq/element-web#23722

Screenshots / GIFs

Tests

For my tests, I mocked locally the data (setting the CryptoDeviceInfo to null)

Enable new Session manager labs flag
Go to "Settings -> Security & Privacy -> Show all sessions"
Check the UI for the current session is correct
Press a session entry in the other sessions list which does support encryption
Check the UI for the session overview screen is correct
Press "Learn more"
Check the displayed text is correct

Tested devices

Physical
Emulator
OS version(s): Android 11

Checklist

Changes has been tested on an Android device or Android emulator with API 21
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR
If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

ElementBot · 2022-12-07T15:19:01Z

...src/main/java/im/vector/app/features/settings/devices/v2/overview/SessionOverviewFragment.kt

-        } else {
-            R.string.device_manager_learn_more_sessions_unverified
+    private fun showLearnMoreInfoVerificationStatus(roomEncryptionTrustLevel: RoomEncryptionTrustLevel?) {
+        val args = when(roomEncryptionTrustLevel) {


🚫 Missing spacing after "when"

ElementBot · 2022-12-07T15:19:01Z

...tor/app/features/settings/devices/v2/verification/GetEncryptionTrustLevelForDeviceUseCase.kt

@@ -25,11 +25,15 @@ class GetEncryptionTrustLevelForDeviceUseCase @Inject constructor(
        private val getEncryptionTrustLevelForOtherDeviceUseCase: GetEncryptionTrustLevelForOtherDeviceUseCase,
 ) {

-    fun execute(currentSessionCrossSigningInfo: CurrentSessionCrossSigningInfo, cryptoDeviceInfo: CryptoDeviceInfo?): RoomEncryptionTrustLevel {
+    fun execute(currentSessionCrossSigningInfo: CurrentSessionCrossSigningInfo, cryptoDeviceInfo: CryptoDeviceInfo?): RoomEncryptionTrustLevel? {
+        if(cryptoDeviceInfo == null) {
