Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Session manager] Add actions to rename and signout current session (PSG-885) #7707

Merged
merged 6 commits into from
Dec 7, 2022
Merged

[Session manager] Add actions to rename and signout current session (PSG-885) #7707

merged 6 commits into from
Dec 7, 2022

Conversation

mnaturel
Copy link
Contributor

@mnaturel mnaturel commented Dec 5, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Adding 2 actions in the overflow menu of the current session card view in the new main session manager screen:

  • rename current session
  • signout current session

Motivation and context

Closes #7697

Screenshots / GIFs

Tests

  • Enable the new Session manager in labs settings
  • Go to Settings -> Security & Privacy -> Show all sessions
  • Press the menu in the current session card view
  • Check actions to rename and sign out the session are present
  • Press the rename item
  • Check the rename screen is opened for the current session
  • Rename the session
  • Check it updates the name of the session
  • Press the menu in the current session card view
  • Press the sign out item
  • Check a confirm dialog is displayed
  • Confirm
  • Check the current session is signed out

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel marked this pull request as ready for review December 5, 2022 13:27
@mnaturel mnaturel requested review from a team and ganfra and removed request for a team December 5, 2022 13:28
Base automatically changed from feature/mna/signout-all-other-sessions to develop December 5, 2022 16:50
ganfra
ganfra approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

...or/src/main/java/im/vector/app/features/settings/devices/v2/VectorSettingsDevicesFragment.kt Outdated
activity?.let { SignOutUiWorker(it).perform() }
}

private fun initCurrentSessionListView() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the name should be initDeviceListCurrentSessionView?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree naming is not correct here. I renamed it to initCurrentSessionView() to align with the other methods.

@ElementBot
Copy link

Warnings
⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against a44c8df

@sonarcloud
Copy link

sonarcloud bot commented Dec 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

11.1% 11.1% Coverage
0.0% 0.0% Duplication

@mnaturel mnaturel merged commit c580090 into develop Dec 7, 2022
@mnaturel mnaturel deleted the feature/mna/rename-and-signout-action-current-session branch December 7, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganfra ganfra ganfra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Session manager] Add actions to rename and signout current session
3 participants
@mnaturel @ElementBot @ganfra